Skip to content

Commit 06737ed

Browse files
authored
Merge pull request kubernetes#2675 from adisky/update-credential-provider-KEP
[KEP-2133]: Update milestone and metadata for Kubelet credential provider
2 parents 01abf7d + 0ad4f18 commit 06737ed

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

keps/sig-node/2133-kubelet-credential-providers/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,7 @@ can be achieved using the exec plugin.
341341

342342
* integration or e2e tests.
343343
* at least one working plugin implementation.
344+
- there are two implementation currently for [ECR](https://github.com/kubernetes/cloud-provider-aws/tree/master/cmd/ecr-credential-provider) and [GCR](https://github.com/kubernetes/cloud-provider-gcp/tree/master/cmd/auth-provider-gcp).
344345
* kubelet metrics for failed calls to exec plugins.
345346
* improvements to concurrency and caching:
346347
- use `singleflight.Group` to ensure only a single call per image. Today the kubelet holds a single lock for every call to `Provide`.
@@ -397,7 +398,7 @@ _This section must be completed when targeting beta graduation to a release._
397398

398399
* **Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?**
399400

400-
No, upgrade->downgrade->upgrade were not tested. Manual validation will be done prior to promoting this feature to beta in v1.21.
401+
No, upgrade->downgrade->upgrade were not tested. Manual validation will be done prior to promoting this feature to beta in v1.22.
401402

402403
* **Is the rollout accompanied by any deprecations and/or removals of features, APIs,
403404
fields of API types, flags, etc.?**

keps/sig-node/2133-kubelet-credential-providers/kep.yaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ stage: beta
2727
# The most recent milestone for which work toward delivery of this KEP has been
2828
# done. This can be the current (upcoming) milestone, if it is being actively
2929
# worked on.
30-
latest-milestone: "v1.21"
30+
latest-milestone: "v1.22"
3131

3232
# The milestone at which this feature was, or is targeted to be, at each stage.
3333
milestone:
3434
alpha: "v1.20"
35-
beta: "v1.21"
36-
stable: "v1.23"
35+
beta: "v1.22"
36+
stable: "v1.24"
3737

3838
# The following PRR answers are required at alpha release
3939
# List the feature gate name and the components for which it must be enabled
@@ -44,5 +44,6 @@ feature-gates:
4444
disable-supported: true
4545

4646
# The following PRR answers are required at beta release
47-
# metrics:
48-
# - my_feature_metric
47+
metrics:
48+
- kubelet_credential_provider_plugin_errors
49+
- kubelet_credential_provider_plugin_duration

0 commit comments

Comments
 (0)