You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@@ -150,60 +56,27 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
150
56
151
57
## Summary
152
58
153
-
<!--
154
-
This section is incredibly important for producing high-quality, user-focused
155
-
documentation such as release notes or a development roadmap. It should be
156
-
possible to collect this information before implementation begins, in order to
157
-
avoid requiring implementors to split their attention between writing release
158
-
notes and implementing the feature itself. KEP editors and SIG Docs
159
-
should help to ensure that the tone and content of the `Summary` section is
160
-
useful for a wide audience.
161
-
162
-
A good summary is probably at least a paragraph in length.
59
+
The metric stability framework was originally introduced with the intent of safeguarding significant metrics from being broken downstream. Metrics could be deemed `stable` or `alpha`, and only `stable` metrics would have stability guarantees.
163
60
164
-
Both in this section and below, follow the guidelines of the [documentation
165
-
style guide]. In particular, wrap lines to a reasonable length, to make it
166
-
easier for reviewers to cite specific portions, and to minimize diff churn on
This KEP intends to propose additional stability classes to extend on the existing metrics stability framework, such that we can achieve parity with the various stages of the feature release cycle.
171
62
172
63
## Motivation
173
64
174
-
<!--
175
-
This section is for explicitly listing the motivation, goals, and non-goals of
176
-
this KEP. Describe why the change is important and the benefits to users. The
177
-
motivation section can optionally provide links to [experience reports] to
178
-
demonstrate the interest in a KEP within the wider Kubernetes community.
It's become more obvious recently that we need additional stability classes, particularly in respect to various stages of feature releases. This has become more obvious with the advent of PRR (production readiness reviews) and mandated production readiness metrics.
182
66
183
67
### Goals
184
68
185
-
<!--
186
-
List the specific goals of the KEP. What is it trying to achieve? How will we
187
-
know that this has succeeded?
188
-
-->
69
+
Introduce two more metric classes: `beta`, corresponding to the `beta` stage of feature release, and `internal` which corresponds to internal development related metrics.
70
+
71
+
Additionally we propose forced upgrades of metrics stability classes in the similar vein that features are not allowed to languish in `alpha` or `beta` stages. In order to respect the fact that there may be classes of metrics which do not correspond to features, we reserve the `internal` metrics stability class.
189
72
190
73
### Non-Goals
191
74
192
-
<!--
193
-
What is out of scope for this KEP? Listing non-goals helps to focus discussion
194
-
and make progress.
195
-
-->
75
+
196
76
197
77
## Proposal
198
78
199
-
<!--
200
-
This is where we get down to the specifics of what the proposal actually is.
201
-
This should have enough detail that reviewers can understand exactly what
202
-
you're proposing, but should not include things like API designs or
203
-
implementation. What is the desired outcome and how do we measure success?.
204
-
The "Design Details" section below is for the real
205
-
nitty-gritty.
206
-
-->
79
+
207
80
208
81
### User Stories (Optional)
209
82
@@ -252,23 +125,9 @@ proposal will be implemented, this is the place to discuss them.
252
125
253
126
### Test Plan
254
127
255
-
<!--
256
-
**Note:** *Not required until targeted at a release.*
257
-
258
-
Consider the following in developing a test plan for this enhancement:
259
-
- Will there be e2e and integration tests, in addition to unit tests?
260
-
- How will it be tested in isolation vs with other components?
261
-
262
-
No need to outline all of the test cases, just the general strategy. Anything
263
-
that would count as tricky in the implementation, and anything particularly
264
-
challenging to test, should be called out.
128
+
We have static analysis testing for stable metrics, we will extend our test coverage
129
+
to include metrics which are `ALPHA` and `BETA` while ignoring `INTERNAL` metrics.
265
130
266
-
All code is expected to have adequate tests (eventually with coverage
267
-
expectations). Please adhere to the [Kubernetes testing guidelines][testing-guidelines]
0 commit comments