Skip to content

Commit 09a41a1

Browse files
committed
Added metric
1 parent 82eb73a commit 09a41a1

File tree

1 file changed

+10
-4
lines changed
  • keps/sig-apps/3140-TimeZone-support-in-CronJob

1 file changed

+10
-4
lines changed

keps/sig-apps/3140-TimeZone-support-in-CronJob/README.md

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,9 @@ there are a few cases:
232232
should be no change in behavior.
233233
3. If TimeZone feature gate was not enabled there should be no change in behavior.
234234

235+
Irrespectively of the option, cluster administrator should monitor `cronjob_job_creation_skew`
236+
which reports the skew between schedule and actual job creation.
237+
235238
### Version Skew Strategy
236239

237240
This feature has no node runtime implications.
@@ -286,6 +289,10 @@ rollout. Similarly, consider large clusters and how enablement/disablement
286289
will rollout across nodes.
287290
-->
288291

292+
An upgrade flow can be vulnerable to the enable, disable, enable if you have
293+
a lease that is acquired by a new kube-controller-manager, then an old
294+
kube-controller-manager, then a new kube-controller-manager.
295+
289296
###### What specific metrics should inform a rollback?
290297

291298
<!--
@@ -363,10 +370,9 @@ question.
363370
Pick one more of these and delete the rest.
364371
-->
365372

366-
- [ ] Metrics
367-
- Metric name:
368-
- [Optional] Aggregation method:
369-
- Components exposing the metric:
373+
- [x] Metrics
374+
- Metric name: `cronjob_controller_rate_limiter_use`
375+
- Components exposing the metric: `kube-controller-manager`
370376
- [ ] Other (treat as last resort)
371377
- Details:
372378

0 commit comments

Comments
 (0)