api: Add Document interface and PRR approval types

Signed-off-by: Stephen Augustus <[email protected]>

Author: justaugustus

api/approval.go

@@ -0,0 +1,37 @@
+/*
+Copyright 2021 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package api
+
+type PRRApprovals []*PRRApproval
+
+func (p *PRRApprovals) AddPRRApproval(prrApproval *PRRApproval) {
+	*p = append(*p, prrApproval)
+}
+
+type PRRApproval struct {
+	Number string       `json:"kep-number" yaml:"kep-number"`
+	Alpha  PRRMilestone `json:"alpha" yaml:"alpha,omitempty"`
+	Beta   PRRMilestone `json:"beta" yaml:"beta,omitempty"`
+	Stable PRRMilestone `json:"stable" yaml:"stable,omitempty"`
+
+	Error error `json:"-" yaml:"-"`
+}
+
+// TODO(api): Can we refactor the proposal `Milestone` to retrieve this?
+type PRRMilestone struct {
+	Approver string `json:"approver" yaml:"approver"`
+}

api/document.go

@@ -0,0 +1,21 @@
+/*
+Copyright 2021 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package api
+
+// TODO(api): Populate interface
+// TODO(api): Mock interface
+type Document interface{}

pkg/kepval/prrs/approvals.go

@@ -24,39 +24,21 @@ import (
 	"github.com/pkg/errors"
 	"gopkg.in/yaml.v3"
 
+	"k8s.io/enhancements/api"
 	"k8s.io/enhancements/pkg/kepval/prrs/validations"
 )
 
-type Approvals []*Approval
-
-func (a *Approvals) AddApproval(approval *Approval) {
-	*a = append(*a, approval)
-}
-
-type Milestone struct {
-	Approver string `json:"approver" yaml:"approver"`
-}
-
-type Approval struct {
-	Number string    `json:"kep-number" yaml:"kep-number"`
-	Alpha  Milestone `json:"alpha" yaml:"alpha"`
-	Beta   Milestone `json:"beta" yaml:"beta"`
-	Stable Milestone `json:"stable" yaml:"stable"`
-
-	Error error `json:"-" yaml:"-"`
-}
-
 type Parser struct{}
 
-func (p *Parser) Parse(in io.Reader) *Approval {
+func (p *Parser) Parse(in io.Reader) *api.PRRApproval {
 	scanner := bufio.NewScanner(in)
 	var body bytes.Buffer
 	for scanner.Scan() {
 		line := scanner.Text() + "\n"
 		body.WriteString(line)
 	}
 
-	approval := &Approval{}
+	approval := &api.PRRApproval{}
 	if err := scanner.Err(); err != nil {
 		approval.Error = errors.Wrap(err, "error reading file")
 		return approval