Skip to content

Commit 1208981

Browse files
committed
Update vsphere csi migration test plan
1 parent 8e7bf49 commit 1208981

File tree

2 files changed

+35
-4
lines changed

2 files changed

+35
-4
lines changed

keps/sig-storage/1491-csi-migration-vsphere/README.md

Lines changed: 32 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@
55
<!-- toc -->
66
- [Summary](#summary)
77
- [New Feature Gates](#new-feature-gates)
8+
- [Design Details](#design-details)
9+
- [Prerequisite testing updates](#prerequisite-testing-updates)
10+
- [Unit tests](#unit-tests)
11+
- [Integration tests](#integration-tests)
12+
- [e2e tests](#e2e-tests)
813
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
914
- [Implementation History](#implementation-history)
1015
<!-- /toc -->
@@ -35,6 +40,28 @@ used as as described in its parent KEP. For all other contents, please refer to
3540
on kubelet and treat vSphere CSI migration as already complete. And directly redirect traffic to CSI
3641
driver for all vsphere volume related operations.
3742

43+
## Design Details
44+
[X] I/we understand the owners of the involved components may require updates to
45+
existing tests to make this code solid enough prior to committing the changes necessary
46+
to implement this enhancement.
47+
### Prerequisite testing updates
48+
No additional prerequisite tests are needed.
49+
50+
51+
### Unit tests
52+
Unit tests for vSphere CSI Migration is added in the csi-translation-lib repository
53+
- https://github.com/kubernetes/csi-translation-lib/blob/master/plugins/vsphere_volume_test.go (85.1% coverage)
54+
55+
### Integration tests
56+
- No Integration tests required for this feature
57+
58+
### e2e tests
59+
- Existing e2e tests developed for in-tree vSphere volume plugin executed - https://github.com/kubernetes/kubernetes/tree/master/test/e2e/storage/vsphere
60+
- Additional tests added in the [vSphere CSI Driver repository](https://github.com/kubernetes-sigs/vsphere-csi-driver) to ensure vSphere CSI Migration is production ready.
61+
- https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/vcp_to_csi_create_delete.go
62+
- https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/vcp_to_csi_attach_detach.go
63+
- https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/vcp_to_csi_full_sync.go
64+
- https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/vcp_to_csi_syncer.go
3865

3966
## Production Readiness Review Questionnaire
4067

@@ -54,5 +81,8 @@ Major milestones for vSphere in-tree plugin CSI migration:
5481
- 1.19
5582
- vSphere CSI migration to Beta, off by default
5683

57-
- 1.24
58-
- vSphere CSI migration to Beta, on by default
84+
- 1.25
85+
- vSphere CSI migration to Beta, On by default
86+
87+
- 1.26
88+
- vSphere CSI migration to Stable

keps/sig-storage/1491-csi-migration-vsphere/kep.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ approvers:
1212
- "@msau42"
1313
editor: "@Jiawei0227"
1414
creation-date: 2022-01-11
15-
last-updated: 2022-01-11
15+
last-updated: 2022-08-11
1616
disable-supported: true
1717
status: implementable
1818
see-also:
@@ -27,12 +27,13 @@ stage: beta
2727
# The most recent milestone for which work toward delivery of this KEP has been
2828
# done. This can be the current (upcoming) milestone, if it is being actively
2929
# worked on.
30-
latest-milestone: "v1.24"
30+
latest-milestone: "v1.25"
3131

3232
# The milestone at which this feature was, or is targeted to be, at each stage.
3333
milestone:
3434
alpha: "v1.18"
3535
beta: "v1.19"
36+
stable: "v1.26"
3637

3738
# The following PRR answers are required at alpha release
3839
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)