Skip to content

Commit 124d9e2

Browse files
committed
apply feedback
1 parent 870d966 commit 124d9e2

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

keps/sig-api-machinery/2144-clientgo-apply/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
- [Design Details](#design-details)
1313
- [Apply functions](#apply-functions)
1414
- [Generated apply configuration types](#generated-apply-configuration-types)
15-
- [Alternative 1: Genreated structs where all fields are pointers](#alternative-1-genreated-structs-where-all-fields-are-pointers)
15+
- [Alternative 1: Generated structs where all fields are pointers](#alternative-1-generated-structs-where-all-fields-are-pointers)
1616
- [Alternative 2: Generated "builders"](#alternative-2-generated-builders)
1717
- [Comparison of alternatives](#comparison-of-alternatives)
1818
- [DeepCopy support](#deepcopy-support)
@@ -60,12 +60,12 @@ checklist items _must_ be updated for the enhancement to be released.
6060

6161
Items marked with (R) are required *prior to targeting to a milestone / release*.
6262

63-
- [ ] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
63+
- [x] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
6464
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
65-
- [ ] (R) Design details are appropriately documented
65+
- [x] (R) Design details are appropriately documented
6666
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
67-
- [ ] (R) Graduation criteria is in place
68-
- [ ] (R) Production readiness review completed
67+
- [x] (R) Graduation criteria is in place
68+
- [x] (R) Production readiness review completed
6969
- [ ] Production readiness review approved
7070
- [ ] "Implementation History" section is up-to-date for milestone
7171
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]

keps/sig-api-machinery/2144-clientgo-apply/kep.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ latest-milestone: "v1.21"
2626

2727
# The milestone at which this feature was, or is targeted to be, at each stage.
2828
milestone:
29-
alpha: "v1.19"
30-
beta: "v1.20"
31-
stable: "v1.22"
29+
# alpha: "v1.21"
30+
# beta: "v1.21"
31+
# stable: "v1.21"
3232

3333
# The following PRR answers are required at alpha release
3434
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)