Skip to content

Commit 141ea75

Browse files
committed
Address comments from PRR and SIG-Apps approvers and reviewers
Signed-off-by: Yuki Iwai <[email protected]>
1 parent 6e2ddd3 commit 141ea75

File tree

1 file changed

+9
-12
lines changed
  • keps/sig-apps/3998-job-success-completion-policy

1 file changed

+9
-12
lines changed

keps/sig-apps/3998-job-success-completion-policy/README.md

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -70,16 +70,16 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
7070
- [x] (R) KEP approvers have approved the KEP status as `implementable`
7171
- [x] (R) Design details are appropriately documented
7272
- [x] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
73-
- [ ] e2e Tests for all Beta API Operations (endpoints)
73+
- [x] e2e Tests for all Beta API Operations (endpoints)
7474
- [ ] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
7575
- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
7676
- [x] (R) Graduation criteria is in place
7777
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
7878
- [ ] (R) Production readiness review completed
7979
- [ ] (R) Production readiness review approved
80-
- [ ] "Implementation History" section is up-to-date for milestone
81-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
82-
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
80+
- [x] "Implementation History" section is up-to-date for milestone
81+
- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
82+
- [x] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
8383

8484
[kubernetes.io]: https://kubernetes.io/
8585
[kubernetes/enhancements]: https://git.k8s.io/enhancements
@@ -509,9 +509,8 @@ only for running Jobs and don't update `.status.conditions` for already finished
509509

510510
###### Are there any tests for feature enablement/disablement?
511511

512-
Yes, we will add the following flow integration tests for the new APIs from the alpha stage:
513-
514-
- enablement -> disablement -> re-enablement
512+
Yes, we added the "enablement -> disablement -> re-enablement" flow integration tests for the new APIs from the alpha stage
513+
[here](https://github.com/kubernetes/kubernetes/blob/6346b9d1327c4b8be2398d9715bdae5475e27569/test/integration/job/job_test.go#L794):
515514

516515
### Rollout, Upgrade and Rollback Planning
517516

@@ -533,7 +532,7 @@ specifically the reason.
533532
In the alpha stage, the upgrade->downgrade->upgrade testing was added in the integration tests
534533
[here](https://github.com/kubernetes/kubernetes/blob/6346b9d1327c4b8be2398d9715bdae5475e27569/test/integration/job/job_test.go#L794).
535534

536-
In terms of a manual test for the upgrade and rollback, we can use th v1.30.
535+
In terms of a manual test for the upgrade and rollback, we can use the v1.30.
537536

538537
The upgrade->downgrade->upgrade testing was done manually using the `alpha` version in v1.30 with the following steps:
539538

@@ -605,7 +604,7 @@ verify that the pod with index=2 still running and the Job doesn't have `Success
605604

606605
3. Simulate upgrade by enabling the feature for api server and control-plane.
607606

608-
Then, very that the pod with index=2 is terminated and the Job has `SuccessCriteriaMet` and `Complete` conditions.
607+
Then, verify that the pod with index=2 is terminated and the Job has `SuccessCriteriaMet` and `Complete` conditions.
609608

610609
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
611610

@@ -656,8 +655,6 @@ No.
656655
Yes, if the Job meets the SuccessPolicy,
657656
the job-controller must make an additional API call to update the condition with `SuccessCriteriaMet`.
658657

659-
No.
660-
661658
###### Will enabling / using this feature result in introducing new API types?
662659

663660
No.
@@ -719,7 +716,7 @@ consider tuning the parameters for [APF](https://kubernetes.io/docs/concepts/clu
719716
- 2023.10.03: API design is updated.
720717
- 2024.02.07: API is finalized for the alpha stage.
721718
- 2024.03.09: "Criteria" is replaced with "Rules".
722-
- 2024.06.06: Beta Graduation.
719+
- 2024.06.11: Beta Graduation.
723720

724721
## Drawbacks
725722

0 commit comments

Comments
 (0)