Skip to content

Commit 151a42a

Browse files
committed
address comments
1 parent ae061ad commit 151a42a

File tree

1 file changed

+4
-1
lines changed
  • keps/sig-node/2129-remove-cadvisor-json-metrics

1 file changed

+4
-1
lines changed

keps/sig-node/2129-remove-cadvisor-json-metrics/README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
- [X] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements](https://github.com/kubernetes/enhancements/issues/1867)
3232
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
33-
- [ ] (R) Design details are appropriately documented
33+
- [X] (R) Design details are appropriately documented
3434
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
3535
- [X] (R) Graduation criteria is in place
3636
- [ ] (R) Production readiness review completed
@@ -96,12 +96,14 @@ Remove the `--enable-cadvisor-json-endpoints` flag and the kubelet stops serving
9696
### Test Plan
9797

9898
* This will not have any e2e testing.
99+
* There are no existing kubernetes e2e tests which check these endpoints.
99100

100101
### Graduation Criteria
101102

102103
#### GA Graduation
103104

104105
* The deprecated flag and relevant code have been removed.
106+
* We are moving directly to stable, as the endpoints have already been marked deprecated for at least 2 releases.
105107

106108
### Upgrade / Downgrade Strategy
107109

@@ -165,6 +167,7 @@ Remove the `--enable-cadvisor-json-endpoints` flag and the kubelet stops serving
165167
## Implementation History
166168

167169
- 2020-10-04: Initial version of the KEP
170+
- 2021-02-04: Updates based on feedback
168171

169172
## Drawbacks
170173

0 commit comments

Comments
 (0)