Skip to content

Commit 1732f4a

Browse files
committed
Fix namespace for canleadlease
1 parent 2984c45 commit 1732f4a

File tree

1 file changed

+8
-7
lines changed
  • keps/sig-api-machinery/4355-coordinated-leader-election

1 file changed

+8
-7
lines changed

keps/sig-api-machinery/4355-coordinated-leader-election/README.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ metadata:
269269
name: some-custom-controller-0001A
270270
namespace: kube-system
271271
spec:
272-
canLeadLease: kube-system/some-custom-controller
272+
canLeadLease: some-custom-controller
273273
leaseDurationSeconds: 300
274274
renewTime: "2023-12-05T02:33:08.685777Z"
275275
```
@@ -380,11 +380,12 @@ The `Strategy` field signals to the coordinated leader election controller the
380380
appropriate algorithm to use when selecting leaders.
381381

382382
We will allow the Coordinated Leader Election controller to create a Lease
383-
without a holder. If there are no candidate objects, the `Strategy` field will remain
384-
empty to indicate that the `Lease` is not managed by the CLE controller.
385-
Otherwise the strategy will always default to `MinimumCompatibilityVersion`.
386-
The `Lease` may also be updated by a third party to the desired
387-
`spec.Strategy` if an alternate strategy is preferred. This may be done either by the candidates, users, or additional controllers.
383+
without a holder. If there are no candidate objects, the `Strategy` field will
384+
remain empty to indicate that the `Lease` is not managed by the CLE controller.
385+
Otherwise the strategy will always default to `MinimumCompatibilityVersion`. The
386+
`Lease` may also be updated by a third party to the desired `spec.Strategy` if
387+
an alternate strategy is preferred. This may be done either by the candidates,
388+
users, or additional controllers.
388389

389390
#### Alternative for Strategy
390391

@@ -521,7 +522,7 @@ For the LeaseCandidate leases, a new lease will be created
521522
type LeaseCandidateSpec struct {
522523
// The fields BinaryVersion and CompatibilityVersion will be mandatory labels instead of fields in the spec
523524

524-
// CanLeadLease is in the format <namespace>/<name>, indicating the namespace and name of the lease that the candidate may lead
525+
// CanLeadLease indicates the name of the lease that the candidate may lead
525526
CanLeadLease string
526527

527528
// Strategy indicates the preferred strategy for the coordinated leader election controller to use.

0 commit comments

Comments
 (0)