Skip to content

Commit 183d079

Browse files
committed
kepval: Strip @ from PRR approver during validation
Signed-off-by: Stephen Augustus <[email protected]>
1 parent 7e08693 commit 183d079

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

pkg/kepval/approval.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"fmt"
2121
"os"
2222
"path/filepath"
23+
"strings"
2324

2425
"github.com/blang/semver/v4"
2526
"github.com/pkg/errors"
@@ -71,6 +72,11 @@ func ValidatePRR(kep *api.Proposal, h *api.PRRHandler, prrDir string) error {
7172
}
7273

7374
stagePRRApprover := prr.ApproverForStage(kep.Stage)
75+
76+
if strings.HasPrefix(stagePRRApprover, "@") {
77+
stagePRRApprover = strings.TrimPrefix(stagePRRApprover, "@")
78+
}
79+
7480
validApprover := api.IsOneOf(stagePRRApprover, h.PRRApprovers)
7581
if !validApprover {
7682
return errors.New(

0 commit comments

Comments
 (0)