Skip to content

Commit 185a441

Browse files
committed
KEP-2258: Extend test plan section
Add unit, integration and e2e sections.
1 parent 5b727ac commit 185a441

File tree

1 file changed

+36
-1
lines changed
  • keps/sig-windows/2258-node-service-log-viewer

1 file changed

+36
-1
lines changed

keps/sig-windows/2258-node-service-log-viewer/README.md

Lines changed: 36 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@
1919
- [kubelet](#kubelet)
2020
- [kubectl](#kubectl)
2121
- [Test Plan](#test-plan)
22+
- [Prerequisite testing updates](#prerequisite-testing-updates)
23+
- [Unit tests](#unit-tests)
24+
- [Integration tests](#integration-tests)
25+
- [e2e tests](#e2e-tests)
2226
- [Graduation Criteria](#graduation-criteria)
2327
- [Alpha -> Beta Graduation](#alpha---beta-graduation)
2428
- [Beta -> GA Graduation](#beta---ga-graduation)
@@ -261,9 +265,40 @@ does not log to `/var/log`, the same functionality not available message will be
261265
returned.
262266

263267
### Test Plan
268+
269+
[x] I/we understand the owners of the involved components may require updates to
270+
existing tests to make this code solid enough prior to committing the changes necessary
271+
to implement this enhancement.
272+
273+
##### Prerequisite testing updates
274+
275+
##### Unit tests
276+
264277
Add unit tests to kubelet and kubectl that exercise the new arguments that
265278
have been added. A reference implementation of the tests can be seen
266-
[here](https://github.com/kubernetes/kubernetes/pull/96120/commits/c606a38ec38ccfe486033495a1dc433279ce71f8#diff-1d703a87c6d6156adf2d0785ec0174bb365855d4883f5758c05fda1fee8f7f1bR1)
279+
[here](https://github.com/kubernetes/kubernetes/pull/96120/commits/253dbad91a3896680da74da32595f02120f56cfa#diff-1d703a87c6d6156adf2d0785ec0174bb365855d4883f5758c05fda1fee8f7f1b)
280+
281+
Given that a new kubelet package is introduced as part of this feature there is
282+
no existing test coverage to link to.
283+
284+
##### Integration tests
285+
286+
Given that we need the kubelet running locally to test this feature, integration
287+
tests will not be possible for this feature.
288+
289+
##### e2e tests
290+
291+
We will add a test that query the kubelet service logs on Windows and Linux nodes.
292+
On Windows node, the same kubelet service logs will queried by explicitly
293+
specifying the log file. In Linux the explicit log file query will be tested by
294+
querying a random file in present in /var/log.
295+
296+
On the Linux side tests will be added to [kubelet node](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/node/kubelet.go)
297+
e2e tests. For Windows a new set of tests will be added to the existing
298+
[e2e tests](https://github.com/kubernetes/kubernetes/tree/master/test/e2e/windows).
299+
300+
- node: https://storage.googleapis.com/k8s-triage/index.html?sig=node
301+
- windows: https://storage.googleapis.com/k8s-triage/index.html?sig=windows
267302

268303
### Graduation Criteria
269304

0 commit comments

Comments
 (0)