Skip to content

Commit 203e738

Browse files
committed
Mention that KCM cannot know default labels
1 parent 231e0a7 commit 203e738

File tree

1 file changed

+6
-1
lines changed
  • keps/sig-storage/1710-selinux-relabeling

1 file changed

+6
-1
lines changed

keps/sig-storage/1710-selinux-relabeling/README.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,12 @@ Drawbacks:
606606
* The controller may report a conflict when two Pods are scheduled to the same node, but they will run serially there.
607607
For example, one pod is already being deleted and the other has just been scheduled there.
608608
Kubelet's `volume_manager_selinux_volume_context_mismatch_warnings_total` metric is more accurate in this case.
609-
609+
* The controller cannot read the SELinux default container labels from the operating system.
610+
KCM often runs in a container and does not have access to `/etc/selinux` on the worker nodes.
611+
As consequence, two labels that are equivalent from the SELinux point of view, may be reported as different, such as these two `seLinuxOptions` snippets: `{"type": "container_t", "level": "s0:c10,c0"}` and `{"level": "s0:c10,c1"}`.
612+
`container_t` is the default type label for containers on Fedora, so kubelet is able to fill it in the `seLinuxOptions` when it is not set and see they're equivalent.
613+
KCM does not know the default on nodes and treats these `seLinuxOptions` as different.
614+
610615
### Implementation phases
611616

612617
Due to change of Kubernetes behavior, we will implement the feature only for cases where it can't break anything first.

0 commit comments

Comments
 (0)