Skip to content

Commit 24612d7

Browse files
authored
Update README.md
1 parent d3fdfbd commit 24612d7

File tree

1 file changed

+3
-27
lines changed
  • keps/sig-scheduling/5007-device-attach-before-pod-scheduled

1 file changed

+3
-27
lines changed

keps/sig-scheduling/5007-device-attach-before-pod-scheduled/README.md

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -330,43 +330,19 @@ This issue needs to be resolved before the beta is released.
330330
### DRA Scheduler Plugin Design Overview
331331

332332
This document outlines the design of the DRA Scheduler Plugin, focusing on the handling of fabric devices.
333-
Key additions include new attributes for device identification, enhancements to `AllocatedDeviceStatus`, and the process for handling `ResourceSlices` upon attachment failure.
333+
Key additions include `BindingConditions` and `BindingFailureConditions for device identification and preparetion, enhancements to `AllocatedDeviceStatus.Conditions`, and the process for handling `ResourceSlices` upon attachment failure.
334334
The composable controller design is also discussed, emphasizing efficient utilization of fabric devices.
335335

336336
![proposal](proposal.jpg)
337337

338338
#### BasicDevice Enhancements
339339

340-
To indicate whether a device is a fabric device, fields are added to the `Basic` within `Device`.
340+
To indicate that the device is a Fabric device or other device that requires some preparation (e.g. attachment), some fields are added to the `Basic` within `Device`.
341341
These fields will be used by the controller that exposes the `ResourceSlice` to notify whether the device is a fabric device.
342342

343343
```go
344-
// Device represents one individual hardware instance that can be selected based
345-
// on its attributes. Besides the name, exactly one field must be set.
346-
type Device struct {
347-
// Name is unique identifier among all devices managed by
348-
// the driver in the pool. It must be a DNS label.
349-
//
350-
// +required
351-
Name string
352-
353-
// Basic defines one device instance.
354-
//
355-
// +optional
356-
// +oneOf=deviceType
357-
Basic *BasicDevice
358-
}
359-
360344
// BasicDevice represents a basic device instance.
361345
type BasicDevice struct {
362-
// Attributes defines the set of attributes for this device.
363-
// The name of each attribute must be unique in that set.
364-
//
365-
// The maximum number of attributes and capacities combined is 32.
366-
//
367-
// +optional
368-
Attributes map[QualifiedName]DeviceAttribute
369-
370346
// BindingConditions defines the conditions for binding.
371347
//
372348
// +optional
@@ -562,7 +538,7 @@ And until the device is actually attached to the node, the user does not know wh
562538

563539
Because of this concept, the Pool and ResourceSlice exposed by Composable DRA controller are separate for each model.
564540
The devices in the Pool for each model have unique device names, but are essentially information about how many devices of this model are in the ResourceSlice.
565-
Composable DRA controoler also add a model name and so on into the attributes of each device.
541+
Composable DRA controller also add a model name and so on into the attributes of each device.
566542

567543
![composable-resourceslice](composable-resourceslice.png)
568544

0 commit comments

Comments
 (0)