Skip to content

Commit 2c8296e

Browse files
authored
Merge pull request kubernetes#3359 from humblec/nodeexpansion1.25
KEP-3107: update the test plan for nodeExpandSecret
2 parents 1bb95ed + 7ff58c9 commit 2c8296e

File tree

1 file changed

+29
-1
lines changed
  • keps/sig-storage/3107-csi-nodeexpandsecret

1 file changed

+29
-1
lines changed

keps/sig-storage/3107-csi-nodeexpandsecret/README.md

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@
1717
- [Risks and Mitigations](#risks-and-mitigations)
1818
- [Design Details](#design-details)
1919
- [Test Plan](#test-plan)
20+
- [Prerequisite testing updates](#prerequisite-testing-updates)
21+
- [Unit tests](#unit-tests)
22+
- [Integration tests](#integration-tests)
23+
- [e2e tests](#e2e-tests)
2024
- [Graduation Criteria](#graduation-criteria)
2125
- [Alpha](#alpha)
2226
- [Beta](#beta)
@@ -140,10 +144,34 @@ The same field will be used by Kubernetes to fill secretRef in the
140144
NodeExpandVolume request.
141145

142146
### Test Plan
147+
[X] I/we understand the owners of the involved components may require updates to
148+
existing tests to make this code solid enough prior to committing the changes necessary
149+
to implement this enhancement.
150+
151+
##### Prerequisite testing updates
152+
153+
N/A
154+
155+
##### Unit tests
156+
143157
- Unit tests around all the added logic in kubelet.
144158
- Unit tests around all the added logic in kube-apiserver.
159+
160+
The Unit tests for this feature is available [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/api/persistentvolume/util_test.go#L31)
161+
,[here](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/validation/validation_test.go)
162+
and [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/csi/expander_test.go#L36)
163+
164+
##### Integration tests
165+
166+
N/A
167+
168+
##### e2e tests
169+
145170
- E2E tests around nodeExpandVolume to make sure the field value has passed
146-
and can be used.
171+
and can be used, however these tests require external dependency like external-provisioner
172+
[sidecar](https://github.com/kubernetes-csi/external-provisioner/). Once added this
173+
support to mentioned sidecar, the e2e tests will be added and validated using
174+
example CSI driver [tests](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/drivers/csi-test/driver/driver.go).
147175

148176
### Graduation Criteria
149177

0 commit comments

Comments
 (0)