|
17 | 17 | - [Risks and Mitigations](#risks-and-mitigations)
|
18 | 18 | - [Design Details](#design-details)
|
19 | 19 | - [Test Plan](#test-plan)
|
| 20 | + - [Prerequisite testing updates](#prerequisite-testing-updates) |
| 21 | + - [Unit tests](#unit-tests) |
| 22 | + - [Integration tests](#integration-tests) |
| 23 | + - [e2e tests](#e2e-tests) |
20 | 24 | - [Graduation Criteria](#graduation-criteria)
|
21 | 25 | - [Alpha](#alpha)
|
22 | 26 | - [Beta](#beta)
|
@@ -140,10 +144,34 @@ The same field will be used by Kubernetes to fill secretRef in the
|
140 | 144 | NodeExpandVolume request.
|
141 | 145 |
|
142 | 146 | ### Test Plan
|
| 147 | +[X] I/we understand the owners of the involved components may require updates to |
| 148 | +existing tests to make this code solid enough prior to committing the changes necessary |
| 149 | +to implement this enhancement. |
| 150 | + |
| 151 | +##### Prerequisite testing updates |
| 152 | + |
| 153 | +N/A |
| 154 | + |
| 155 | +##### Unit tests |
| 156 | + |
143 | 157 | - Unit tests around all the added logic in kubelet.
|
144 | 158 | - Unit tests around all the added logic in kube-apiserver.
|
| 159 | + |
| 160 | +The Unit tests for this feature is available [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/api/persistentvolume/util_test.go#L31) |
| 161 | +,[here](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/validation/validation_test.go) |
| 162 | +and [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/csi/expander_test.go#L36) |
| 163 | + |
| 164 | +##### Integration tests |
| 165 | + |
| 166 | +N/A |
| 167 | + |
| 168 | +##### e2e tests |
| 169 | + |
145 | 170 | - E2E tests around nodeExpandVolume to make sure the field value has passed
|
146 |
| - and can be used. |
| 171 | + and can be used, however these tests require external dependency like external-provisioner |
| 172 | + [sidecar](https://github.com/kubernetes-csi/external-provisioner/). Once added this |
| 173 | + support to mentioned sidecar, the e2e tests will be added and validated using |
| 174 | + example CSI driver [tests](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/drivers/csi-test/driver/driver.go). |
147 | 175 |
|
148 | 176 | ### Graduation Criteria
|
149 | 177 |
|
|
0 commit comments