Skip to content

Commit 2fca880

Browse files
committed
add specific configuration options
1 parent 156fb60 commit 2fca880

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

keps/sig-instrumentation/0034-distributed-tracing-kep.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ This KEP proposes the use of the [OpenTelemetry tracing framework](https://opent
8484

8585
The API Server will use the [OpenTelemetry exporter format](https://github.com/open-telemetry/opentelemetry-proto), which exports traces to a local port. This format is compatible with the [OpenTelemetry Collector](https://github.com/open-telemetry/opentelemetry-collector), which allows importing and configuring exporters for trace storage backends to be done out-of-tree in addition to other useful features. The exporter stores spans in memory, and uses the [batching processor](https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#batching-processor) to batch requests and send them asynchronously.
8686

87-
Add configuration to the API Server required to configure the opentelemetry exporter, including the address and egress proxy to send spans to. The [egress proxy](https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190226-network-proxy.md) can be added to the opentelemetry exporter by adding a ContextDialer grpc DialOption similar to the one used by the apiserver's etcd client.
87+
Add configuration to the API Server required to configure the opentelemetry exporter, including the address and egress proxy to send spans to. The [egress proxy](https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190226-network-proxy.md) can be added to the opentelemetry exporter by adding a ContextDialer grpc DialOption similar to the one used by the apiserver's etcd client. This will add a new "OpenTelemetry" [EgressType](https://github.com/kubernetes/kubernetes/blob/4b9b9ab75376b7b53876ab6b2be42d0940c7eb26/staging/src/k8s.io/apiserver/pkg/server/egressselector/egress_selector.go#L53) to the API Server's configuration.
8888

8989
### Controlling use of the OpenTelemetry library
9090

@@ -95,15 +95,13 @@ As the community found in the [Metrics Stability Framework KEP](https://github.c
9595
Alpha
9696

9797
- [] Implement tracing of incoming and outgoing http/grpc requests in the kube-apiserver
98-
- [] Add a `--trace` flag to kubectl
9998
- [] E2e testing of apiserver tracing
10099
- [] User-facing documentation
101100

102101
Beta
103102

104-
- [] Benchmark kubernetes components using tracing
103+
- [] Tracing 100% of requests does not break scalability tests.
105104
- [] Publish documentation on examples of how to use the OT Collector with kubernetes
106-
- [] Scalability testing
107105

108106

109107
## Alternatives considered

0 commit comments

Comments
 (0)