Skip to content

Commit 33f3b54

Browse files
committed
Address PRR feedback
1 parent 753eeca commit 33f3b54

File tree

1 file changed

+13
-4
lines changed
  • keps/sig-storage/1495-volume-populators

1 file changed

+13
-4
lines changed

keps/sig-storage/1495-volume-populators/README.md

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -365,9 +365,8 @@ _This section must be completed when targeting alpha to a release._
365365
None.
366366

367367
* **Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?**
368-
Describe manual testing that was done and the outcomes.
369-
Longer term, we may want to require automated upgrade/rollback tests, but we
370-
are missing a bunch of machinery and tooling and can't do that now.
368+
Yes, we are testing the upgrade and rollback paths on the prototype implementation
369+
as we go, and will manually test the finished version.
371370

372371
* **Is the rollout accompanied by any deprecations and/or removals of features, APIs,
373372
fields of API types, flags, etc.?**
@@ -383,6 +382,11 @@ _This section must be completed when targeting beta graduation to a release._
383382
existence of any VolumePopulator.populator.storage.k8s.io CRs would indicate
384383
that a populator is installed and could be used.
385384

385+
As the controller itself is out of tree, the administrator or distro must
386+
install it (similar to the volume snapshot controller) and we will use the
387+
same mechanisms as the volume snapshot controller for installation and
388+
health monitoring.
389+
386390
* **What are the SLIs (Service Level Indicators) an operator can use to determine
387391
the health of the service?**
388392
- [ ] Metrics
@@ -436,7 +440,12 @@ the existing API objects?**
436440

437441
* **Will enabling / using this feature result in increasing time taken by any
438442
operations covered by [existing SLIs/SLOs]?**
439-
No.
443+
No. PVC creation already takes an unbounded amount of time. It is valid to
444+
create a PVC with a data source that does not yet exist, and to create that
445+
data source later. This feature maintains that status quo ante, and in all
446+
cases, ensures that some controller is responsible for generating feedback
447+
on the progress of the PVC creation so users can understand why operations
448+
are not yet finished.
440449

441450
* **Will enabling / using this feature result in non-negligible increase of
442451
resource usage (CPU, RAM, disk, IO, ...) in any components?**

0 commit comments

Comments
 (0)