Skip to content

Commit 37ca567

Browse files
authored
Merge pull request kubernetes#2619 from ahg-g/ahg-cost-beta
Promote PodDeletionCost to Beta
2 parents 4e3596d + 5d008d5 commit 37ca567

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
kep-number: 2255
22
alpha:
33
approver: "@wojtek-t"
4+
beta:
5+
approver: "@wojtek-t"

keps/sig-apps/2255-pod-cost/README.md

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,16 @@
3535

3636
Items marked with (R) are required *prior to targeting to a milestone / release*.
3737

38-
- [ ] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
39-
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
40-
- [ ] (R) Design details are appropriately documented
41-
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
42-
- [ ] (R) Graduation criteria is in place
43-
- [ ] (R) Production readiness review completed
44-
- [ ] Production readiness review approved
45-
- [ ] "Implementation History" section is up-to-date for milestone
46-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
47-
- [ ] Supporting documentation e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
38+
- [X] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
39+
- [X] (R) KEP approvers have approved the KEP status as `implementable`
40+
- [X] (R) Design details are appropriately documented
41+
- [X] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
42+
- [X] (R) Graduation criteria is in place
43+
- [X] (R) Production readiness review completed
44+
- [X] Production readiness review approved
45+
- [X] "Implementation History" section is up-to-date for milestone
46+
- [X] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
47+
- [X] Supporting documentation e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
4848

4949

5050
[kubernetes.io]: https://kubernetes.io/
@@ -193,7 +193,7 @@ It should continue to work as expected.
193193

194194

195195
* **Are there any tests for feature enablement/disablement?**
196-
We will add unit tests.
196+
Unit tests.
197197

198198
### Rollout, Upgrade and Rollback Planning
199199

@@ -207,7 +207,7 @@ since users need to explicitly set the annotation.
207207
None.
208208

209209
* **Were upgrade and rollback tested? Was upgrade->downgrade->upgrade path tested?**
210-
We will do manual testing.
210+
Manually tested, worked as expected.
211211

212212
* **Is the rollout accompanied by any deprecations and/or removals of features,
213213
APIs, fields of API types, flags, etc.?**
@@ -275,6 +275,7 @@ _This section must be completed when targeting beta graduation to a release._
275275

276276
* **How does this feature react if the API server and/or etcd is unavailable?**
277277
- The pod annotation can't be set. The normal pod deletion behavior will be used for non-annotated pods in a Deployment.
278+
278279
* **What are other known failure modes?**
279280
- None.
280281

@@ -285,6 +286,7 @@ _This section must be completed when targeting beta graduation to a release._
285286
[existing SLIs/SLOs]: https://git.k8s.io/community/sig-scalability/slos/slos.md#kubernetes-slisslos
286287

287288
## Implementation History
289+
- 2021-04-11: Promoted the feature to Beta
288290
- 2021-01-13: Initial KEP submitted as provisional
289291
- 2021-01-15: KEP promoted to implementable
290292

keps/sig-apps/2255-pod-cost/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ see-also:
2222

2323

2424
# The target maturity stage in the current dev cycle for this KEP.
25-
stage: alpha
25+
stage: beta
2626

2727
# The most recent milestone for which work toward delivery of this KEP has been
2828
# done. This can be the current (upcoming) milestone, if it is being actively

0 commit comments

Comments
 (0)