Skip to content

Commit 394fe46

Browse files
committed
move test plan to its own section in kubelet resource metric kep
1 parent 819ae1d commit 394fe46

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

keps/sig-node/kubelet-resource-metrics-endpoint.md

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ status: implementable
3838
- [Results](#results-1)
3939
- [Alternatives Considered](#alternatives-considered)
4040
- [gRPC API](#grpc-api)
41+
- [Test Plan](#test-plan)
4142
- [Graduation Criteria](#graduation-criteria)
4243
- [Implementation History](#implementation-history)
4344
<!-- /toc -->
@@ -204,17 +205,23 @@ service ResourceMetrics {
204205
}
205206
```
206207

208+
### Test Plan
209+
210+
Test the new endpoint with a node-e2e test similar to the current summary API test.
211+
Testgrid: https://k8s-testgrid.appspot.com/sig-node-kubelet#node-kubelet-features-master&include-filter-by-regex=ResourceMetricsAPI
212+
207213
## Graduation Criteria
208214

209215
Alpha:
210216

211-
- [ ] Implement the kubelet resource metrics endpoint as described above
212-
- [ ] Test the new endpoint with a node-e2e test similar to the current summary API test
217+
- [X] Implement the kubelet resource metrics endpoint as described above
218+
219+
Beta:
220+
213221
- [ ] Modify the metrics server to consume the kubelet resource metrics endpoint 3 releases after it is added to the kubelet
214222

215-
Beta/GA:
223+
GA:
216224

217-
- [ ] Determine whether a transition to OpenMetrics format is required, and make those changes if necessary
218225
- [ ] Add node-e2e test to the node conformance tests
219226

220227
## Implementation History

0 commit comments

Comments
 (0)