Skip to content

Commit 3d9d7d4

Browse files
authored
Merge pull request kubernetes#2650 from ahg-g/ahg-nss-beta
graduate pod affinity namespaceselector to beta
2 parents a20d3a6 + 19f9054 commit 3d9d7d4

File tree

3 files changed

+17
-7
lines changed

3 files changed

+17
-7
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
kep-number: 2249
22
alpha:
33
approver: "@wojtek-t"
4+
beta:
5+
approver: "@wojtek-t"

keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,8 @@ proposal will be implemented, this is the place to discuss them.
398398
- feature gate enabled/disabled
399399
- Benchmark Tests:
400400
- evaluate performance for the case where the selector matches a large number of pods
401-
in large number of namespaces
401+
in large number of namespaces. The evaluation shows that using NamespaceSelector has no
402+
impact on performance (see https://github.com/kubernetes/kubernetes/pull/101329 for details).
402403

403404
<!--
404405
**Note:** *Not required until targeted at a release.*
@@ -487,7 +488,10 @@ in back-to-back releases.
487488

488489
### Upgrade / Downgrade Strategy
489490

490-
N/A
491+
In the event of an upgrade, kube-apiserver will start accepting NamespaceSelector and the
492+
new CrossNamespaceAffinity quota scope.
493+
494+
In the event of a downgrade, kube-scheduler will ignore NamespaceSelector even if it was set.
491495

492496
### Version Skew Strategy
493497

@@ -546,7 +550,7 @@ _This section must be completed when targeting alpha to a release._
546550
It should continue to work as expected.
547551

548552
* **Are there any tests for feature enablement/disablement?**
549-
No, but we can do manual testing.
553+
Yes, unit tests exist.
550554

551555

552556
### Rollout, Upgrade and Rollback Planning
@@ -566,7 +570,7 @@ _This section must be completed when targeting beta graduation to a release._
566570

567571

568572
* **Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?**
569-
No, will be manually tested.
573+
Manually tested successfully.
570574

571575
* **Is the rollout accompanied by any deprecations and/or removals of features, APIs,
572576
fields of API types, flags, etc.?**
@@ -656,7 +660,9 @@ not get assigned nodes.
656660
N/A
657661

658662
* **What steps should be taken if SLOs are not being met to determine the problem?**
659-
N/A
663+
664+
Check `plugin_execution_duration_seconds{plugin="InterPodAffinity"}` to see if latency increased. Note
665+
that latency increases with number of existing pods.
660666

661667
[supported limits]: https://git.k8s.io/community//sig-scalability/configs-and-limits/thresholds.md
662668
[existing SLIs/SLOs]: https://git.k8s.io/community/sig-scalability/slos/slos.md#kubernetes-slisslos
@@ -679,6 +685,7 @@ information to express the idea and why it was not acceptable.
679685
## Implementation History
680686
- 2021-01-11: Initial KEP sent for review
681687
- 2021-02-10: Remove the restriction on empty namespace selector
688+
- 2021-04-26: Graduate the feature to Beta
682689

683690
<!--
684691
Major milestones in the lifecycle of a KEP should be tracked in this section.

keps/sig-scheduling/2249-pod-affinity-namespace-selector/kep.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ prr-approvers:
1919
see-also:
2020

2121
# The target maturity stage in the current dev cycle for this KEP.
22-
stage: alpha
22+
stage: beta
2323

2424
# The most recent milestone for which work toward delivery of this KEP has been
2525
# done. This can be the current (upcoming) milestone, if it is being actively
@@ -43,4 +43,5 @@ disable-supported: true
4343

4444
# The following PRR answers are required at beta release
4545
metrics:
46-
- TBD
46+
- schedule_attempts_total{result="error|unschedulable"}
47+
- plugin_execution_duration_seconds{plugin="InterPodAffinity"}

0 commit comments

Comments
 (0)