Skip to content

Commit 3e6d42d

Browse files
committed
KEP-1965: add SLO and metrics for # of expected leases
Signed-off-by: Andrew Sy Kim <[email protected]>
1 parent 03e1e9b commit 3e6d42d

File tree

1 file changed

+5
-2
lines changed
  • keps/sig-api-machinery/1965-kube-apiserver-identity

1 file changed

+5
-2
lines changed

keps/sig-api-machinery/1965-kube-apiserver-identity/README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,8 +262,9 @@ the Lease object to see if workloads or other controllers are relying on this fe
262262

263263
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
264264

265-
A rough SLO here is that healthy kube-apiservers has a lease which is not older than 2 times the frequency of
266-
the lease heart beat 95% of time.
265+
Some reasonable SLOs could be:
266+
* Number of (non-expired) Leases in `kube-apiserver-leases` is equal to the number of expected kube-apiservers 95% of the time.
267+
* kube-apiservers hold a lease which is not older than 2 times the frequency of the lease heart beat 95% of time.
267268

268269
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
269270

@@ -277,6 +278,8 @@ the lease heart beat 95% of time.
277278
A metric measuring the last updated time for a lease could be useful, but it could introduce cardinality problems
278279
since the lease is changed on every restart of kube-apiserver.
279280

281+
We may consider adding a metric exposing the count of leases in `kube-apiserver-lease`.
282+
280283
### Dependencies
281284

282285
###### Does this feature depend on any specific services running in the cluster?

0 commit comments

Comments
 (0)