Skip to content

Commit 4030bd8

Browse files
authored
Merge pull request kubernetes#3385 from palnabarun/canonical-kep-number-json-field
api: correct JSON field name for Proposal.Number
2 parents 27ddd8f + b18527d commit 4030bd8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

api/approval.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ func (p *PRRApprovals) AddPRRApproval(prrApproval *PRRApproval) {
3434
}
3535

3636
type PRRApproval struct {
37-
Number string `json:"kep-number" yaml:"kep-number" validate:"required"`
37+
Number string `json:"kepNumber" yaml:"kep-number" validate:"required"`
3838

3939
// TODO: Need to validate these milestone pointers are not nil
4040
Alpha *PRRMilestone `json:"alpha" yaml:"alpha,omitempty"`

api/proposal.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ type Proposal struct {
9797
Name string `json:"name,omitempty"`
9898

9999
Title string `json:"title" yaml:"title" validate:"required"`
100-
Number string `json:"kep-number" yaml:"kep-number" validate:"required"`
100+
Number string `json:"kepNumber" yaml:"kep-number" validate:"required"`
101101
Authors []string `json:"authors" yaml:",flow" validate:"required"`
102102
OwningSIG string `json:"owningSig" yaml:"owning-sig" validate:"required"`
103103
ParticipatingSIGs []string `json:"participatingSigs" yaml:"participating-sigs,flow,omitempty"`

0 commit comments

Comments
 (0)