pkg: Move kepctl testdata to repo package

Signed-off-by: Stephen Augustus <[email protected]>

Author: justaugustus

pkg/repo/query.go

@@ -117,7 +117,7 @@ func (r *Repo) Query(opts *QueryOpts) error {
 	// load the KEPs for each listed SIG
 	for _, sig := range opts.Groups {
 		// KEPs in the local filesystem
-		allKEPs = append(allKEPs, r.loadLocalKEPs(sig)...)
+		allKEPs = append(allKEPs, r.LoadLocalKEPs(sig)...)
 
 		// Open PRs; existing KEPs with open PRs will be shown twice
 		if opts.IncludePRs {

pkg/repo/repo.go

@@ -224,7 +224,7 @@ func (r *Repo) findLocalKEPMeta(sig string) ([]string, error) {
 	return keps, err
 }
 
-func (r *Repo) loadLocalKEPs(sig string) []*api.Proposal {
+func (r *Repo) LoadLocalKEPs(sig string) []*api.Proposal {
 	// KEPs in the local filesystem
 	files, err := r.findLocalKEPMeta(sig)
 	if err != nil {

pkg/kepctl/kepctl_test.go renamed to pkg/repo/repo_test.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package kepctl
+package repo_test
 
 import (
 	"fmt"
@@ -25,6 +25,7 @@ import (
 	"gopkg.in/yaml.v3"
 
 	"k8s.io/enhancements/api"
+	"k8s.io/enhancements/pkg/repo"
 )
 
 func TestValidate(t *testing.T) {
@@ -34,12 +35,12 @@ func TestValidate(t *testing.T) {
 		err  error
 	}{
 		{
-			name: "valid kep passes valdiate",
+			name: "valid KEP passes validate",
 			file: "testdata/valid-kep.yaml",
 			err:  nil,
 		},
 		{
-			name: "invalid kep fails valdiate for owning-sig",
+			name: "invalid KEP fails validate for owning-sig",
 			file: "testdata/invalid-kep.yaml",
 			err:  fmt.Errorf(`kep is invalid: error validating KEP metadata: "owning-sig" must be one of (committee-code-of-conduct,committee-product-security,committee-steering,sig-api-machinery,sig-apps,sig-architecture,sig-auth,sig-autoscaling,sig-cli,sig-cloud-provider,sig-cluster-lifecycle,sig-contributor-experience,sig-docs,sig-instrumentation,sig-multicluster,sig-network,sig-node,sig-release,sig-scalability,sig-scheduling,sig-security,sig-service-catalog,sig-storage,sig-testing,sig-ui,sig-usability,sig-windows,ug-big-data,ug-vmware-users,wg-api-expression,wg-component-standard,wg-data-protection,wg-iot-edge,wg-k8s-infra,wg-lts,wg-multitenancy,wg-naming,wg-policy,wg-security-audit) but it is a string: sig-awesome`),
 		},
@@ -49,10 +50,12 @@ func TestValidate(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			b, err := ioutil.ReadFile(tc.file)
 			require.NoError(t, err)
+
 			var p api.Proposal
 			err = yaml.Unmarshal(b, &p)
 			require.NoError(t, err)
-			err = validateKEP(&p)
+
+			err = p.Validate()
 			if tc.err == nil {
 				require.NoError(t, err)
 			} else {
@@ -77,15 +80,16 @@ func TestFindLocalKEPs(t *testing.T) {
 		},
 	}
 
-	c, clientErr := New("testdata")
-	require.Nil(t, clientErr)
+	r, repoErr := repo.New("testdata")
+	require.Nil(t, repoErr)
 
 	for i, tc := range testcases {
-		k := c.loadLocalKEPs("testdata", tc.sig)
+		k := r.LoadLocalKEPs(tc.sig)
 		if len(k) != len(tc.keps) {
 			t.Errorf("Test case %d: expected %d but got %d", i, len(tc.keps), len(k))
 			continue
 		}
+
 		for j, kn := range k {
 			if kn.Name != tc.keps[j] {
 				t.Errorf("Test case %d: expected %s but got %s", i, tc.keps[j], kn.Name)

pkg/kepctl/testdata/invalid-kep.yaml renamed to pkg/repo/testdata/invalid-kep.yaml

@@ -15,4 +15,4 @@ approvers:
 creation-date: 2020-04-14
 last-updated: 2020-04-15
 stage: "alpha"
-status: provisional
+status: provisional

pkg/kepctl/testdata/templates/README.md renamed to pkg/repo/testdata/keps/NNNN-kep-template/README.md

@@ -12,7 +12,7 @@ approvers:
   - "@mikedanese"
   - "@deads2k"
   - "@liggitt"
-stage: "alpha"
 creation-date: 2020-04-14
 last-updated: 2020-04-15
-status: provisional
+stage: "alpha"
+status: provisional

pkg/kepctl/testdata/keps/sig-architecture/123-newstyle/kep.yaml renamed to pkg/repo/testdata/keps/NNNN-kep-template/kep.yaml

@@ -12,7 +12,7 @@ approvers:
   - "@mikedanese"
   - "@deads2k"
   - "@liggitt"
+stage: "alpha"
 creation-date: 2020-04-14
 last-updated: 2020-04-15
-stage: "alpha"
-status: provisional
+status: provisional