Skip to content

Commit 43d4d84

Browse files
committed
Apply feedback, update authors, reviewers, sigs
1 parent 6d3bfc4 commit 43d4d84

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

keps/sig-architecture/4330-compatibility-versions/README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,9 @@ Kubernetes components (apiservers, controller managers, schedulers) will offer a
268268
minor versions. If unset, the compatibility version defaults to the `<major.minor>`
269269
version of the binary version.
270270

271+
The kubelet is out of scope for this enhancement. Note that the kubelet already
272+
supports N-3 version skew with the kube-apiserver.
273+
271274
### Changes to Feature Gates
272275

273276
Features will track version information, i.e.:
@@ -326,7 +329,7 @@ The lifecycle of the feature would be:
326329
| 1.28 | GA | Alpha: 1.26, Beta: 1.27 (on-by-default), GA: 1.28 |
327330
| 1.29 | GA | Alpha: 1.26, Beta: 1.27 (on-by-default), GA: 1.28 |
328331
| 1.30 | GA | Alpha: 1.26, Beta: 1.27 (on-by-default), GA: 1.28 |
329-
| 1.31 | GA | **Feature implementation becomes part of normal code, Feature gate and feature tracking information may be removed from code** |
332+
| 1.31 | GA | **Feature implementation becomes part of normal code. `if featureGate enabled { // implement feature }` code may be removed at this step** |
330333

331334
All feature gating and tracking must remain in code through 1.30 for N-3
332335
compatibility version support.
@@ -354,7 +357,7 @@ The steps to remove the Beta feature would be:
354357
| 1.30 | - | Beta: 1.26, Deprecated: 1.27, Removed: 1.31 |
355358
| 1.31 | - | Beta: 1.26, Deprecated: 1.27, Removed: 1.31 |
356359
| 1.32 | - | Beta: 1.26, Deprecated: 1.27, Removed: 1.31 |
357-
| 1.33 | - | **Feature implementation and feature tracking information may be removed from code** |
360+
| 1.33 | - | **`if featureGate enabled { // implement feature }` code may be removed at this step** |
358361

359362
(Features that are deleted before reaching Beta do not require n-3 compatibility
360363
support since we don't support compatibility version for alpha features)

keps/sig-architecture/4330-compatibility-versions/kep.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
11
title: Compatibility Versions
22
kep-number: 4330
33
authors:
4-
- "@logicalhan"
4+
- "@alexzielenski"
55
- "@jpbetz"
66
- "@liggitt"
7+
- "@logicalhan"
78
- "@siyuanfoundation"
8-
owning-sig: sig-api-machinery
9+
owning-sig: sig-architecture
910
participating-sigs:
10-
- sig-architecture
11+
- sig-api-machinery
1112
- wg-lts
1213
status: provisional
1314
creation-date: 2023-12-01
1415
reviewers:
1516
- "@deads2k"
1617
- "@thockin"
18+
- "@wojtek-t"
19+
- "@dims"
1720
approvers:
1821
- "@johnbelamaric"
1922
- "@dims"

0 commit comments

Comments
 (0)