Skip to content

Commit 4409f9d

Browse files
committed
sidecar: Update TOC
Signed-off-by: Rodrigo Campos <[email protected]>
1 parent 8ad75f2 commit 4409f9d

File tree

1 file changed

+10
-44
lines changed

1 file changed

+10
-44
lines changed

keps/sig-node/0753-sidecarcontainers.md

Lines changed: 10 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -39,55 +39,21 @@ status: provisional
3939
- [Goals](#goals)
4040
- [Non-Goals](#non-goals)
4141
- [Proposal](#proposal)
42-
- [Implementation Details/Notes/Constraints](#implementation-detailsnotesconstraints)
43-
- [API Changes:](#api-changes)
44-
- [Kubelet Changes:](#kubelet-changes)
45-
- [Shutdown triggering](#shutdown-triggering)
46-
- [Sidecars terminated last](#sidecars-terminated-last)
47-
- [Sidecars started first](#sidecars-started-first)
48-
- [PreStop hooks sent to Sidecars first](#prestop-hooks-sent-to-sidecars-first)
49-
- [Proposal decisions to discuss](#proposal-decisions-to-discuss)
50-
- [preStop hooks delivery guarantees are changed](#prestop-hooks-delivery-guarantees-are-changed)
51-
- [Alternative 1: add a TerminationHook](#alternative-1-add-a-terminationhook)
52-
- [Alternative 2: Do nothing](#alternative-2-do-nothing)
53-
- [Suggestion](#suggestion)
54-
- [Killing pods take 3x the time](#killing-pods-take-3x-the-time)
55-
- [Why is it important to discuss this?](#why-is-it-important-to-discuss-this)
56-
- [Alternatives to kill the pod in the expected time](#alternatives-to-kill-the-pod-in-the-expected-time)
57-
- [How to split the shutdown time to kill different types of containers?](#how-to-split-the-shutdown-time-to-kill-different-types-of-containers)
58-
- [Alternative 1: Allow any step to consume all and be over <code>GraceTime</code> by 8s](#alternative-1-allow-any-step-to-consume-all-and-be-over--by-8s)
59-
- [Alternative 2: Allow any step to consume all and skip preStop hooks](#alternative-2-allow-any-step-to-consume-all-and-skip-prestop-hooks)
60-
- [Alternative 3: Allow any step to consume all and be over <code>GraceTime</code> by 0s](#alternative-3-allow-any-step-to-consume-all-and-be-over--by-0s)
61-
- [Alternative 4: Allow any step to consume all and use 6s as minimum <code>GraceTime</code>](#alternative-4-allow-any-step-to-consume-all-and-use-6s-as-minimum-)
62-
- [Alternative 5: Use <em>per container</em> terminations](#alternative-5-use-per-container-terminations)
63-
- [Suggestion](#suggestion-1)
64-
- [Currently not handling the case of pod=nil](#currently-not-handling-the-case-of-podnil)
42+
- [Notes/Constraints/Caveats](#notesconstraintscaveats)
6543
- [Pods with RestartPolicy Never](#pods-with-restartpolicy-never)
66-
- [Alternative 1: Add a per container fatalToPod field](#alternative-1-add-a-per-container-fataltopod-field)
67-
- [Alternative 2: Do nothing](#alternative-2-do-nothing-1)
68-
- [Alternative 2: Always restart sidecar containers](#alternative-2-always-restart-sidecar-containers)
69-
- [Suggestion](#suggestion-2)
44+
- [Modify killContainer() to enforece gracePeriodOverride on preStop hooks](#modify-killcontainer-to-enforece-graceperiodoverride-on-prestop-hooks)
45+
- [Time to kill a pod increased by 4 seconds in the worst case](#time-to-kill-a-pod-increased-by-4-seconds-in-the-worst-case)
7046
- [Enforce the startup/shutdown behavior only on startup/shutdown](#enforce-the-startupshutdown-behavior-only-on-startupshutdown)
71-
- [Sidecar containers won't be available during initContainers phase](#sidecar-containers-wont-be-available-during-initcontainers-phase)
72-
- [Suggestion](#suggestion-3)
73-
- [Revisit if we want to modify the podPhase](#revisit-if-we-want-to-modify-the-podphase)
74-
- [Alternative 1: don't change the pod phase](#alternative-1-dont-change-the-pod-phase)
75-
- [Alternative 2: change the pod phase](#alternative-2-change-the-pod-phase)
76-
- [Suggestion](#suggestion-4)
77-
- [No container type standard](#no-container-type-standard)
78-
- [Is this change really worth doing?](#is-this-change-really-worth-doing)
79-
- [Kubernetes jobs with sidecars](#kubernetes-jobs-with-sidecars)
80-
- [Service mesh](#service-mesh-1)
81-
- [Kubernetes pods that run indefinitely with sidecars](#kubernetes-pods-that-run-indefinitely-with-sidecars)
82-
- [Summary](#summary-1)
83-
- [Why this design seems extensible?](#why-this-design-seems-extensible)
84-
- [What if we add pre-defined phases for container startup/shutdown?](#what-if-we-add-pre-defined-phases-for-container-startupshutdown)
85-
- [What if we add &quot;Depends On&quot; semantics to containers?](#what-if-we-add-depends-on-semantics-to-containers)
47+
- [Risks and Mitigations](#risks-and-mitigations)
48+
- [Design Details](#design-details)
49+
- [API Changes:](#api-changes)
50+
- [Kubelet Changes:](#kubelet-changes)
51+
- [Shutdown triggering](#shutdown-triggering)
52+
- [Sidecars terminated last](#sidecars-terminated-last)
53+
- [Sidecars started first](#sidecars-started-first)
8654
- [Proof of concept implementations](#proof-of-concept-implementations)
8755
- [KEP implementation and Demo](#kep-implementation-and-demo)
8856
- [Another implementation using pod annotations](#another-implementation-using-pod-annotations)
89-
- [Risks and Mitigations](#risks-and-mitigations)
90-
- [Design Details](#design-details)
9157
- [Test Plan](#test-plan)
9258
- [Graduation Criteria](#graduation-criteria)
9359
- [Alpha -&gt; Beta Graduation](#alpha---beta-graduation)

0 commit comments

Comments
 (0)