kepctl create: add enough flags to work

I do not recommend using `kepctl create` right now; validation and
argument parsing needs work. I wanted to make sure I hadn't broken it
with recent changes and realized it already didn't work.

So I added just enough flags until validation stopped yelling at me, and
I was able to run the following command to get a file created in
keps/sig-testing/first-try/kep.yaml

    kepctl create \
      --name first-try \
      --number not-a-number \
      --title testing-kepctl-create \
      --owning-sig sig-testing

Author: spiffxp

pkg/kepctl/commands/create.go

@@ -28,10 +28,10 @@ func addCreate(topLevel *cobra.Command) {
 	co := proposal.CreateOpts{}
 
 	cmd := &cobra.Command{
-		Use:           "create [KEP]",
+		Use:           "create",
 		Short:         "Create a new KEP",
 		Long:          "Create a new KEP using the current KEP template for the given type",
-		Example:       `  kepctl create sig-architecture/000-mykep`,
+		Example:       `  kepctl create --name a-path --title "My KEP" --number 123 --owning-sig sig-foo`,
 		SilenceUsage:  true,
 		SilenceErrors: true,
 		PreRunE: func(cmd *cobra.Command, args []string) error {
@@ -50,6 +50,20 @@ func addCreate(topLevel *cobra.Command) {
 		"KEP Title",
 	)
 
+	cmd.PersistentFlags().StringVar(
+		&co.Number,
+		"number",
+		"",
+		"Number",
+	)
+
+	cmd.PersistentFlags().StringVar(
+		&co.Name,
+		"name",
+		"",
+		"Name",
+	)
+
 	cmd.PersistentFlags().StringArrayVar(
 		&co.Authors,
 		"authors",
@@ -79,9 +93,16 @@ func addCreate(topLevel *cobra.Command) {
 		"KEP State",
 	)
 
+	cmd.PersistentFlags().StringVar(
+		&co.SIG,
+		"owning-sig",
+		"",
+		"Owning SIG",
+	)
+
 	cmd.PersistentFlags().StringArrayVar(
-		&co.SIGS,
-		"sigs",
+		&co.ParticipatingSIGs,
+		"participating-sigs",
 		[]string{},
 		"Participating SIGs",
 	)

pkg/proposal/create.go

@@ -41,14 +41,14 @@ type CreateOpts struct {
 	SIG    string
 
 	// Create options
-	Title        string
-	Approvers    []string
-	Authors      []string
-	Reviewers    []string
-	Type         string
-	State        string
-	SIGS         []string
-	PRRApprovers []string
+	Title             string
+	Approvers         []string
+	Authors           []string
+	Reviewers         []string
+	Type              string
+	State             string
+	ParticipatingSIGs []string
+	PRRApprovers      []string
 }
 
 // Validate checks the args provided to the create command and parses the sig,
@@ -121,6 +121,8 @@ func createKEP(kep *api.Proposal, opts *CreateOpts) error {
 }
 
 func populateProposal(p *api.Proposal, opts *CreateOpts) {
+	p.Name = opts.Name
+
 	if opts.State != "" {
 		p.Status = opts.State
 	}
@@ -157,7 +159,7 @@ func populateProposal(p *api.Proposal, opts *CreateOpts) {
 
 	// TODO(lint): appendAssign: append result not assigned to the same slice (gocritic)
 	//nolint:gocritic
-	p.ParticipatingSIGs = append(opts.SIGS, opts.SIG)
+	p.ParticipatingSIGs = append(opts.ParticipatingSIGs, opts.SIG)
 	p.Filename = opts.Name
 	p.LastUpdated = "v1.19"