|
12 | 12 | - [Risks and Mitigations](#risks-and-mitigations)
|
13 | 13 | - [Design Details](#design-details)
|
14 | 14 | - [Test Plan](#test-plan)
|
15 |
| - - [Prerequisite testing updates](#prerequisite-testing-updates) |
16 |
| - - [Unit tests](#unit-tests) |
17 |
| - - [Integration tests](#integration-tests) |
18 |
| - - [e2e tests](#e2e-tests) |
| 15 | + - [Prerequisite testing updates](#prerequisite-testing-updates) |
| 16 | + - [Unit tests](#unit-tests) |
| 17 | + - [Integration tests](#integration-tests) |
| 18 | + - [e2e tests](#e2e-tests) |
19 | 19 | - [Graduation Criteria](#graduation-criteria)
|
20 | 20 | - [Alpha -> Beta Graduation](#alpha---beta-graduation)
|
21 | 21 | - [Beta -> GA Graduation](#beta---ga-graduation)
|
@@ -92,31 +92,40 @@ It should be noted that if a CSI driver advertises `VOLUME_MOUNT_GROUP` node cap
|
92 | 92 |
|
93 | 93 | ### Test Plan
|
94 | 94 |
|
95 |
| -#### Prerequisite testing updates |
| 95 | +[x] I/we understand the owners of the involved components may require updates to |
| 96 | +existing tests to make this code solid enough prior to committing the changes necessary |
| 97 | +to implement this enhancement. |
96 | 98 |
|
97 |
| -N/A. |
| 99 | +##### Prerequisite testing updates |
98 | 100 |
|
99 |
| -#### Unit tests |
| 101 | +N/A. |
100 | 102 |
|
101 |
| -Test that whenever supported pod's `fsGroup` should be passed to CSI driver via `volume_mount_group` field. |
| 103 | +##### Unit tests |
102 | 104 |
|
103 |
| -For alpha feature: |
104 |
| -1. Update Azure File CSI driver to support supplying `fsGroup` via `NodeStageVolume` and `NodePublishVolume`. |
105 |
| -1. Run manual tests against azurefile CSI driver. |
| 105 | +The new coded added should have complete test coverage, even though the module does not: |
106 | 106 |
|
107 |
| -For beta: |
108 |
| -1. E2E tests that verify volume readability/writability using azurefile CSI driver. |
109 |
| -2. E2E tests using CSI mock driver. |
| 107 | +- `pkg/volume/csi`: `<Thu 06 Oct 2022>` - `76.2` |
110 | 108 |
|
111 |
| -#### Integration tests |
| 109 | +##### Integration tests |
112 | 110 |
|
113 | 111 | No integration tests are required. This feature is better tested with e2e tests.
|
114 | 112 |
|
115 |
| -#### e2e tests |
| 113 | +##### e2e tests |
116 | 114 |
|
117 | 115 | We already have quite a few e2e tests that verify generic fsgroup functionality for existing drivers - https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/testsuites/fsgroupchangepolicy.go. This should give us a reasonable
|
118 | 116 | confidence that we won't break any existing drivers.
|
119 | 117 |
|
| 118 | + |
| 119 | +- [[sig-storage] CSI mock volume Delegate FSGroup to CSI driver [LinuxOnly] should pass FSGroup to CSI driver if it is set in pod and driver supports VOLUME_MOUNT_GROUP [Suite:openshift/conformance/parallel] [Suite:k8s]](https://storage.googleapis.com/k8s-triage/index.html?test=CSI%20mock%20volume%20Delegate%20FSGroup%20to%20CSI%20driver%20%5BLinuxOnly%5D%20should%20pass%20FSGroup%20to%20CSI%20driver%20if%20it%20is%20set%20in%20pod%20and%20driver%20supports%20VOLUME_MOUNT_GROUP) |
| 120 | +- [[sig-storage] In-tree Volumes [Driver: azure-file] [Testpattern: Dynamic PV (default fs)] fsgroupchangepolicy (Always)[LinuxOnly], pod created with an initial fsgroup, new pod fsgroup applied to volume contents [Suite:openshift/conformance/parallel] [Suite:k8s]](https://storage.googleapis.com/k8s-triage/index.html?test=%5Bsig-storage%5D%20In-tree%20Volumes%20%5BDriver%3A%20azure-file%5D%20%5BTestpattern%3A%20Dynamic%20PV%20(default%20fs)%5D%20fsgroupchangepolicy%20(Always)%5BLinuxOnly%5D%2C%20pod%20created%20with%20an%20initial%20fsgroup%2C%20new%20pod%20fsgroup%20applied%20to%20volume%20contents%20) |
| 121 | +- [[sig-storage] In-tree Volumes [Driver: azure-file] [Testpattern: Dynamic PV (default fs)] fsgroupchangepolicy (Always)[LinuxOnly], pod created with an initial fsgroup, volume contents ownership changed via chgrp in first pod, new pod with different fsgroup applied to the volume contents [Suite:openshift/conformance/parallel] [Suite:k8s]](https://storage.googleapis.com/k8s-triage/index.html?test=%5Bsig-storage%5D%20In-tree%20Volumes%20%5BDriver%3A%20azure-file%5D%20%5BTestpattern%3A%20Dynamic%20PV%20(default%20fs)%5D%20fsgroupchangepolicy%20(Always)%5BLinuxOnly%5D%2C%20pod%20created%20with%20an%20initial%20fsgroup%2C%20volume%20contents%20ownership%20changed%20via%20chgrp%20in%20first%20pod%2C%20new%20pod%20with%20different%20fsgroup%20applied%20to%20the%20volume%20contents) |
| 122 | +- [[sig-storage] In-tree Volumes [Driver: azure-file] [Testpattern: Dynamic PV (default fs)] fsgroupchangepolicy (Always)[LinuxOnly], pod created with an initial fsgroup, volume contents ownership changed via chgrp in first pod, new pod with same fsgroup applied to the volume contents [Suite:openshift/conformance/parallel] [Suite:k8s]](https://storage.googleapis.com/k8s-triage/index.html?test=%5Bsig-storage%5D%20In-tree%20Volumes%20%5BDriver%3A%20azure-file%5D%20%5BTestpattern%3A%20Dynamic%20PV%20(default%20fs)%5D%20fsgroupchangepolicy%20(Always)%5BLinuxOnly%5D%2C%20pod%20created%20with%20an%20initial%20fsgroup%2C%20volume%20contents%20ownership%20changed%20via%20chgrp%20in%20first%20pod%2C%20new%20pod%20with%20same%20fsgroup%20applied%20to%20the%20volume%20contents%20) |
| 123 | +- [[sig-storage] In-tree Volumes [Driver: azure-file] [Testpattern: Dynamic PV (default fs)] fsgroupchangepolicy (OnRootMismatch)[LinuxOnly], pod created with an initial fsgroup, new pod fsgroup applied to volume contents [Suite:openshift/conformance/parallel] [Suite:k8s]](https://storage.googleapis.com/k8s-triage/index.html?test=%5Bsig-storage%5D%20In-tree%20Volumes%20%5BDriver%3A%20azure-file%5D%20%5BTestpattern%3A%20Dynamic%20PV%20(default%20fs)%5D%20fsgroupchangepolicy%20(OnRootMismatch)%5BLinuxOnly%5D%2C%20pod%20created%20with%20an%20initial%20fsgroup%2C%20new%20pod%20fsgroup%20applied%20to%20volume%20contents%20) |
| 124 | +- [[sig-storage] In-tree Volumes [Driver: azure-file] [Testpattern: Dynamic PV (default fs)] fsgroupchangepolicy (OnRootMismatch)[LinuxOnly], pod created with an initial fsgroup, volume contents ownership changed via chgrp in first pod, new pod with different fsgroup applied to the volume contents [Suite:openshift/conformance/parallel] [Suite:k8s]](https://storage.googleapis.com/k8s-triage/index.html?test=%5Bsig-storage%5D%20In-tree%20Volumes%20%5BDriver%3A%20azure-file%5D%20%5BTestpattern%3A%20Dynamic%20PV%20(default%20fs)%5D%20fsgroupchangepolicy%20(OnRootMismatch)%5BLinuxOnly%5D%2C%20pod%20created%20with%20an%20initial%20fsgroup%2C%20volume%20contents%20ownership%20changed%20via%20chgrp%20in%20first%20pod%2C%20new%20pod%20with%20different%20fsgroup%20applied%20to%20the%20volume%20contents%20) |
| 125 | +- [[sig-storage] In-tree Volumes [Driver: azure-file] [Testpattern: Dynamic PV (default fs)] fsgroupchangepolicy (OnRootMismatch)[LinuxOnly], pod created with an initial fsgroup, volume contents ownership changed via chgrp in first pod, new pod with same fsgroup skips ownership changes to the volume contents [Suite:openshift/conformance/parallel] [Suite:k8s]](https://storage.googleapis.com/k8s-triage/index.html?test=%5Bsig-storage%5D%20In-tree%20Volumes%20%5BDriver%3A%20azure-file%5D%20%5BTestpattern%3A%20Dynamic%20PV%20(default%20fs)%5D%20fsgroupchangepolicy%20(OnRootMismatch)%5BLinuxOnly%5D%2C%20pod%20created%20with%20an%20initial%20fsgroup%2C%20volume%20contents%20ownership%20changed%20via%20chgrp%20in%20first%20pod%2C%20new%20pod%20with%20same%20fsgroup%20skips%20ownership%20changes%20to%20the%20volume%20contents) |
| 126 | +- [[sig-storage] In-tree Volumes [Driver: azure-file] [Testpattern: Dynamic PV (default fs)] provisioning should provision storage with mount options [Suite:openshift/conformance/parallel] [Suite:k8s]](https://storage.googleapis.com/k8s-triage/index.html?test=%5Bsig-storage%5D%20In-tree%20Volumes%20%5BDriver%3A%20azure-file%5D%20%5BTestpattern%3A%20Dynamic%20PV%20(default%20fs)%5D%20provisioning%20should%20provision%20storage%20with%20mount%20options%20) |
| 127 | + |
| 128 | + |
120 | 129 | ### Graduation Criteria
|
121 | 130 |
|
122 | 131 | #### Alpha -> Beta Graduation
|
|
0 commit comments