Skip to content

Commit 4f21ed3

Browse files
committed
Update wording
1 parent 92a64d8 commit 4f21ed3

File tree

1 file changed

+3
-2
lines changed
  • keps/sig-scheduling/5142-pop-backoffq-when-activeq-empty

1 file changed

+3
-2
lines changed

keps/sig-scheduling/5142-pop-backoffq-when-activeq-empty/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,8 @@ Flushing from backoffQ to activeQ is done each second, taking all pods with back
179179
It means that, when they come to activeQ, they are sorted by priority there and taken in this order from activeQ.
180180
It is important, because preemption of a lower priority pod could happen if a higher priority pod is scheduled later.
181181

182-
To mitigate this, `lessFn` function of backoffQ's heap will be changed, quantifying the time to make one second windows in which pods will be sorted by priority.
182+
To mitigate this, `lessFn` function of backoffQ's heap will be changed, splitting the time to make one second windows (by ignoring milliseconds)
183+
in which pods will be sorted by priority.
183184
Those whole windows will be eventually flushed to activeQ, making no change in current behavior.
184185

185186
## Design Details
@@ -218,7 +219,7 @@ At the moveToActiveQ level, these two paths could be distinguished by checking i
218219
As [mentioned](#low-priority-pod-could-be-chosen-to-pop-even-if-high-priority-pod-has-a-slightly-later-backoff-expiration) in risks,
219220
backoffQ's heap `lessFn` function has to be changed to apply priority within 1 second windows.
220221
The actual implementation takes backoff expiration times of two pods and compares which is lower.
221-
The new version will cut the milliseconds and use priorities to compare pods within those windows.
222+
The new version will ignore the milliseconds and use priorities to compare pods within those windows.
222223
To make ordering predictable, in case of equal priorities within the same window,
223224
the whole backoff time expiration will be eventually compared. See the pseudocode:
224225

0 commit comments

Comments
 (0)