Skip to content

Commit 5107c19

Browse files
committed
Fix spelling mistakes and pointed out sentence
1 parent a5a07b0 commit 5107c19

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

keps/sig-scheduling/5007-device-attach-before-pod-scheduled/README.md

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ This issue needs to be resolved before the beta is released.
330330
### DRA Scheduler Plugin Design Overview
331331

332332
This document outlines the design of the DRA Scheduler Plugin, focusing on the handling of fabric devices.
333-
Key additions include `BindingConditions` and `BindingFailureConditions` for device identification and preparetion, enhancements to `AllocatedDeviceStatus`, and the process for handling `ResourceSlices` upon attachment failure.
333+
Key additions include `BindingConditions` and `BindingFailureConditions` for device identification and preparation, enhancements to `AllocatedDeviceStatus`, and the process for handling `ResourceSlices` upon attachment failure.
334334
The composable controller design is also discussed, emphasizing efficient utilization of fabric devices.
335335

336336
![proposal](proposal.jpg)
@@ -343,7 +343,7 @@ These fields will be used by the controller that exposes the `ResourceSlice` to
343343
```go
344344
// BasicDevice represents a basic device instance.
345345
type BasicDevice struct {
346-
// BindingConditions defines the conditions for binding.
346+
// BindingConditions defines the conditions for proceeding with binding. All listed conditions must be True to proceed with binding.
347347
//
348348
// +optional
349349
BindingConditions []string
@@ -360,11 +360,11 @@ type BasicDevice struct {
360360
// +optional
361361
UsageRestrictedToNode bool
362362

363-
// BindingTimeoutSeconds indicates the prepare timeout period.
364-
// If the timeout period is exceeded, the scheduler clears the allocation in the ResourceClaim and reschedules the Pod.
363+
// BindingTimeout indicates the prepare timeout period.
364+
// If the timeout period is exceeded before all BindingConditions reach a True state, the scheduler clears the allocation in the ResourceClaim and reschedules the Pod.
365365
//
366366
// +optional
367-
BindingTimeoutSeconds *metav1.Duration
367+
BindingTimeout *metav1.Duration
368368
}
369369

370370
const (
@@ -385,28 +385,28 @@ For this feature, following fields are added:
385385
// driver chooses to report it. This may include driver-specific information.
386386
type AllocatedDeviceStatus struct {
387387
...
388-
// BindingConditions defines the conditions for binding.
388+
// BindingConditions defines the conditions for proceeding with binding. All listed conditions must be True to proceed with binding.
389389
//
390390
// +optional
391391
BindingConditions []string
392392

393393
// BindingFailureConditions defines the conditions for binding failure.
394-
// If true, a binding failure occurred.
394+
// If any is True, a binding failure occurred.
395395
//
396396
// +optional
397-
BindingFailureConditions []stirng
397+
BindingFailureConditions []string
398398

399399
// UsageRestrictedToNode indicates if the usage of an allocation involving this device
400400
// has to be limited to exactly the node that was chosen when allocating the claim.
401401
//
402402
// +optional
403403
UsageRestrictedToNode bool
404404

405-
// BindingTimeoutSeconds indicates the prepare timeout period.
406-
// If the timeout period is exceeded, the scheduler clears the allocation in the ResourceClaim and reschedules the Pod.
405+
// BindingTimeout indicates the prepare timeout period.
406+
// If the timeout period is exceeded before all BindingConditions reach a True state, the scheduler clears the allocation in the ResourceClaim and reschedules the Pod.
407407
//
408408
// +optional
409-
BindingTimeoutSeconds *metav1.Duration
409+
BindingTimeout *metav1.Duration
410410
}
411411
```
412412

@@ -418,11 +418,11 @@ When `UsageRestrictedToNode: true` is set, the scheduler DRA plugin will perform
418418

419419
If Conditions are present, the scheduler DRA plugin will perform the following steps during the `PreBind` phase:
420420

421-
2. **Copy Conditions**: Copy `UsageRestrictedToNode`, `BindingTimeoutSeconds`, `BindingConditions` and `BindingFailureConditions` from `ResourceSlice.Device.Basic` to `AllocatedDeviceStatus`.
421+
2. **Copy Conditions**: Copy `UsageRestrictedToNode`, `BindingTimeout`, `BindingConditions` and `BindingFailureConditions` from `ResourceSlice.Device.Basic` to `AllocatedDeviceStatus`.
422422
3. **Wait for Conditions**: Wait for the following conditions:
423423
- Wait until all conditions in the BindingConditions are `True` before proceeding to Bind.
424424
- If any one of the conditions in the BindingFailureConditions becomes `True`, clear the allocation in the `ResourceClaim` and reschedule the Pod.
425-
- If the preparation of a device takes longer than the `BindingTimeoutSeconds` period, clear the allocation in the `ResourceClaim` and reschedule the Pod.
425+
- If the preparation of a device takes longer than the `BindingTimeout` period, clear the allocation in the `ResourceClaim` and reschedule the Pod.
426426

427427
To support these steps, for example, a DRA driver can include the following definitions in BindingConditions or BindingFailureConditions within a ResourceSlice:
428428

@@ -669,7 +669,7 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
669669
#### Beta
670670

671671
- Gather feedback from developers and surveys
672-
- Resolove the following issues
672+
- Resolve the following issues
673673
- Scheduler does not guarantee to pick up the same node for the Pod after the restart
674674
- If Scheduler picks up another node for the Pod after the restart, devices are unnecessarily left on the original nodes
675675
(Composable DRA controller needs to have the function to detach a device automatically if it is not used by a Pod for a certain period of time)
@@ -761,7 +761,7 @@ well as the [existing list] of feature gates.
761761
-->
762762

763763
- [x] Feature gate (also fill in values in `kep.yaml`)
764-
- Feature gate name: DRAPrebindingConditions
764+
- Feature gate name: DRADeviceBindingConditions
765765
- Components depending on the feature gate: kube-scheduler
766766
- [ ] Other
767767
- Describe the mechanism:

keps/sig-scheduling/5007-device-attach-before-pod-scheduled/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ milestone:
3939
# The following PRR answers are required at alpha release
4040
# List the feature gate name and the components for which it must be enabled
4141
feature-gates:
42-
- name: DRAPrebindingConditions
42+
- name: DRADeviceBindingConditions
4343
components:
4444
- kube-scheduler
4545
disable-supported: true
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)