Skip to content

Commit 51d7764

Browse files
committed
Add PRR for KEP 1923
Signed-off-by: Dave Chen <[email protected]>
1 parent 7e0d642 commit 51d7764

File tree

3 files changed

+22
-3
lines changed

3 files changed

+22
-3
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
kep-number: 1923
2+
alpha:
3+
approver: "@wojtek-t"

keps/sig-scheduling/1923-prefer-nominated-node/README.md

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
2626
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
2727
- [x] (R) Design details are appropriately documented
2828
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
29-
- [ ] (R) Graduation criteria is in place
29+
- [x] (R) Graduation criteria is in place
3030
- [ ] (R) Production readiness review completed
31-
- [ ] Production readiness review approved
31+
- [ ] (R) Production readiness review approved
3232
- [ ] "Implementation History" section is up-to-date for milestone
3333
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
3434
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
@@ -146,6 +146,19 @@ _This section must be completed when targeting alpha to a release._
146146
- Feature gate name: PreferNominatedNode
147147
- Components depending on the feature gate: kube-scheduler
148148

149+
* **Does enabling the feature change any default behavior?**
150+
Yes. The pod with the nominated node set will be evaluated first in any scheduling cycle,
151+
this is only the default process logic that is handled by scheduler, end-user will not
152+
and need not aware of any difference.
153+
154+
* **Can the feature be disabled once it has been enabled (i.e. can we roll back
155+
the enablement)?**
156+
Yes. This could be opt-out by the feature gate, once switch off, it will fall back
157+
to original behavior.
158+
159+
* **What happens if we reenable the feature if it was previously rolled back?**
160+
Nothing needs to be aware of for the end-user.
161+
149162
* **Are there any tests for feature enablement/disablement?**
150163
unittest will cover this.
151164

keps/sig-scheduling/1923-prefer-nominated-node/kep.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,11 @@ reviewers:
1414
approvers:
1515
- "@Huang-Wei"
1616
- "@ahg-g"
17+
prr-approvers:
18+
- "@wojtek-t"
19+
1720
stage: alpha
18-
# latest-milestone: "v1.21"
21+
latest-milestone: "v1.21"
1922
milestone:
2023
alpha: "v1.21"
2124
beta: "v1.22"

0 commit comments

Comments
 (0)