Skip to content

Commit 529c9d6

Browse files
jpbetzneolit123
andauthored
Apply suggestions from code review
Co-authored-by: Lubomir I. Ivanov <[email protected]>
1 parent 88de519 commit 529c9d6

File tree

1 file changed

+5
-5
lines changed
  • keps/sig-api-machinery/4355-coordinated-leader-election

1 file changed

+5
-5
lines changed

keps/sig-api-machinery/4355-coordinated-leader-election/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ expires, the component is considered unavailable for leader election purposes.
252252

253253
### Coordinated Election Controller
254254

255-
A Coordinated Election Controller will reconcile component Leader Leases
255+
A new Coordinated Election Controller will reconcile component Leader Leases
256256
(primary resource) and Identity Leases (secondary resource, changes trigger
257257
reconciliation of related leader leases).
258258

@@ -378,9 +378,9 @@ A cluster administrator upgrades a cluster's control plane node-by-node,
378378
expecting version skew to be respected.
379379

380380
- When the first and second nodes are upgraded, any components that were leaders
381-
will typically loose the lease during the node downtime
382-
- If one happens to retain it's lease, it will be preempted by the coordinated
383-
election controller after it updates it's identity lease with new version
381+
will typically lose the lease during the node downtime
382+
- If one happens to retain its lease, it will be preempted by the coordinated
383+
election controller after it updates its identity lease with new version
384384
information
385385
- When the third node is upgraded, all components will be at the new version and one
386386
will be elected
@@ -430,7 +430,7 @@ nodes, API Server Identity adds 3 leases.
430430
This risk can be migitated by scale testing and, if needed, extending the lease
431431
duration and renewal times to reduce writes/s.
432432

433-
#### Risk: leases watches increases apiserver load substantially
433+
#### Risk: lease watches increase apiserver load substantially
434434

435435
The [Unknown Version Interoperability Proxy (UVIP) enhancement](../4020-unknown-version-interoperability-proxy) also adds
436436
lease watches on [API Server Identity](../1965-kube-apiserver-identity) leases in the kube-system namespace.

0 commit comments

Comments
 (0)