Skip to content

Commit 58528a9

Browse files
committed
Take care of review comments.
1 parent d28b0bb commit 58528a9

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

keps/prod-readiness/sig-node/4540.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
kep-number: 4540
2+
alpha:
3+
approver: "@soltysh"
24
beta:
35
approver: "@soltysh"
4-

keps/sig-node/4540-strict-cpu-reservation/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ The concern is, when the feature graduates to `Stable`, it will be enabled by de
139139

140140
However, this is exactly the feature intent, best-effort workloads have no KPI requirement, they are meant to consume whatever CPU resources left on the node including starving from time to time. Best-effort workloads are not scheduled to run on the `reservedSystemCPUs` so they shall not be run on the `reservedSystemCPUs` to destablize the whole node.
141141

142-
Nevertheless, risk mitigation has been discussed in details (see archived options below) and we agree to start with the following node metrics of cpu pool sizes in Alpha and Beta stages to assess the actual impact in real deployment before revisiting if we need risk mitigation.
142+
Nevertheless, risk mitigation has been discussed in details (see archived options below) and we agree to start with the following node metrics of cpu pool sizes in Alpha and Beta stages to assess the actual impact in real deployment. The plan is to move the current implementation to Stable stage if no field issue is observed for one year.
143143

144144
https://github.com/kubernetes/kubernetes/pull/127506
145145
- `cpu_manager_shared_pool_size_millicores`: report shared pool size, in millicores (e.g. 13500m), expected to be non-zone otherwise best-effort pods will starve

0 commit comments

Comments
 (0)