Merge pull request kubernetes#3346 from kerthcet/feature/ga-conponent-config

Feat: graduate kube-scheduler component config to GA

Author: k8s-ci-robot

keps/prod-readiness/sig-scheduling/785.yaml

@@ -1,3 +1,5 @@
 kep-number: 785
 beta:
   approver: "@wojtek-t"
+stable:
+  approver: "@wojtek-t"

keps/sig-scheduling/785-scheduler-component-config-api/README.md

@@ -10,6 +10,10 @@
   - [Risks and Mitigations](#risks-and-mitigations)
 - [Design Details](#design-details)
   - [Test Plan](#test-plan)
+      - [Prerequisite testing updates](#prerequisite-testing-updates)
+      - [Unit tests](#unit-tests)
+      - [Integration tests](#integration-tests)
+      - [e2e tests](#e2e-tests)
   - [Graduation Criteria](#graduation-criteria)
     - [Alpha -> Beta Graduation](#alpha---beta-graduation)
     - [Beta -> GA Graduation](#beta---ga-graduation)
@@ -35,7 +39,7 @@
 - [x] (R) Production readiness review completed
 - [x] Production readiness review approved
 - [x] "Implementation History" section is up-to-date for milestone
-- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
+- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
 - [ ] Supporting documentation e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
 
 [kubernetes.io]: https://kubernetes.io/
@@ -133,13 +137,93 @@ This will be documented in https://kubernetes.io/docs/reference/scheduling/profi
 
 ### Test Plan
 
+<!--
+**Note:** *Not required until targeted at a release.*
+The goal is to ensure that we don't accept enhancements with inadequate testing.
+
+All code is expected to have adequate tests (eventually with coverage
+expectations). Please adhere to the [Kubernetes testing guidelines][testing-guidelines]
+when drafting this test plan.
+
+[testing-guidelines]: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md
+-->
+
 - [x] Compatibility tests for defaults and overrides of `.bindTimeoutSeconds`
   in `VolumeBindingArgs` type.
 - [x] Tests for `RequestedToCapacityRatioArgs` that: (1) fail to pass with
   bad casing and (2) get encoded with lower case.
 - [x] Tests for parsing, conversion, defaulting and validation.
 - [] Tests which assert predictability of node assignment with increased weights.
 
+[x] I/we understand the owners of the involved components may require updates to
+existing tests to make this code solid enough prior to committing the changes necessary
+to implement this enhancement.
+
+##### Prerequisite testing updates
+
+<!--
+Based on reviewers feedback describe what additional tests need to be added prior
+implementing this enhancement to ensure the enhancements have also solid foundations.
+-->
+None
+
+##### Unit tests
+
+<!--
+In principle every added code should have complete unit test coverage, so providing
+the exact set of tests will not bring additional value.
+However, if complete unit test coverage is not possible, explain the reason of it
+together with explanation why this is acceptable.
+-->
+
+<!--
+Additionally, for Alpha try to enumerate the core package you will be touching
+to implement this enhancement and provide the current unit coverage for those
+in the form of:
+- <package>: <date> - <current test coverage>
+The data can be easily read from:
+https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit
+
+This can inform certain test coverage improvements that we want to do before
+extending the production code to implement this enhancement.
+-->
+
+- `cmd/kube-scheduler/app`: `2022-06-13` -  `32.2%`
+- `cmd/kube-scheduler/app/options`: `2022-06-13` -  `42.2%`
+- `pkg/scheduler/apis/config/scheme`: `2022-06-13` - `100%`
+- `pkg/scheduler/apis/config/v1`: `2022-06-13` - `0%`
+- `pkg/scheduler/apis/config/validation`: `2022-06-13` - `93.9%`
+
+
+##### Integration tests
+
+<!--
+This question should be filled when targeting a release.
+For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
+
+For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
+https://storage.googleapis.com/k8s-triage/index.html
+-->
+We have no special integration tests to cover the graduation of Component Config. But we do
+cover the latest Component Config in scheduling by using the latest version. See
+- [Configuring plugins with the latest Component Config](https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler/plugins/plugins_test.go)
+- [Preemption](https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler/preemption/preemption_test.go)
+- [Queueing](https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler/queue_test.go)
+- [Scheduling in score](https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler/scoring/priorities_test.go)
+
+##### e2e tests
+
+<!--
+This question should be filled when targeting a release.
+For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
+
+For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
+https://storage.googleapis.com/k8s-triage/index.html
+
+We expect no non-infra related flakes in the last month as a GA graduation criteria.
+-->
+None.
+
 ### Graduation Criteria
 
 #### Alpha -> Beta Graduation
@@ -228,6 +312,12 @@ N/A
   When `v1` gets introduced:
   - Mark `v1beta2` as deprecated.
 
+* **Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?**
+
+  Yes, when `v1` gets introduced, we'll mark `v1beta2` as deprecated, and
+  remove the support of `v1beta2` in 1.26.
+
+
 ### Monitoring requirements
 
 * **How can an operator determine if the feature is in use by workloads?**
@@ -252,6 +342,18 @@ N/A
 
   N/A.
 
+* **What are the reasonable SLOs (Service Level Objectives) for the enhancement?**
+
+  N/A
+
+* **What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?**
+
+  N/A
+
+* **Are there any missing metrics that would be useful to have to improve observability of this feature?**
+
+  N/A
+
 ### Dependencies
 
 * **Does this feature depend on any specific services running in the cluster?**

keps/sig-scheduling/785-scheduler-component-config-api/kep.yaml

@@ -17,7 +17,8 @@ prr-approvers:
 see-also:
   - "/keps/sig-scheduling/1451-multi-scheduling-profiles"
   - "/keps/sig-scheduling/2458-node-resource-score-strategy"
-stage: beta
-latest-milestone: "v1.23"
+stage: stable
+latest-milestone: "v1.25"
 milestone:
   beta: "v1.19"
+  stable: "v1.25"