Ensure GitHub token is set

ehashman · ehashman · commit 5adce6934a5f · 2021-05-05T12:55:31.000-07:00
diff --git a/pkg/kepctl/commands/query.go b/pkg/kepctl/commands/query.go
@@ -110,6 +110,7 @@ func runQuery(opts *repo.QueryOpts) error {
 	if err != nil {
 		return errors.Wrap(err, "creating repo client")
 	}
+	rc.TokenPath = rootOpts.TokenPath
 
 	return rc.Query(opts)
 }
diff --git a/pkg/repo/query.go b/pkg/repo/query.go
@@ -110,8 +110,11 @@ func (r *Repo) Query(opts *QueryOpts) error {
 		fmt.Fprintf(r.Out, "Searching for KEPs...\n")
 	}
 
-	if tokenErr := r.SetGitHubToken(r.TokenPath); tokenErr != nil {
-		return errors.Wrapf(tokenErr, "setting GitHub token")
+	if r.TokenPath != "" {
+		logrus.Infof("Setting GitHub token: %v", r.TokenPath)
+		if tokenErr := r.SetGitHubToken(r.TokenPath); tokenErr != nil {
+			return errors.Wrapf(tokenErr, "setting GitHub token")
+		}
 	}
 
 	allKEPs := make([]*api.Proposal, 0, 10)

Original file line number	Diff line number	Diff line change
`@@ -110,6 +110,7 @@ func runQuery(opts *repo.QueryOpts) error {`
`110`	`110`	`if err != nil {`
`111`	`111`	`return errors.Wrap(err, "creating repo client")`
`112`	`112`	`}`
	`113`	`+ rc.TokenPath = rootOpts.TokenPath`
`113`	`114`
`114`	`115`	`return rc.Query(opts)`
`115`	`116`	`}`
Original file line number	Diff line number	Diff line change
`@@ -110,8 +110,11 @@ func (r Repo) Query(opts QueryOpts) error {`
`110`	`110`	`fmt.Fprintf(r.Out, "Searching for KEPs...\n")`
`111`	`111`	`}`
`112`	`112`
`113`		`- if tokenErr := r.SetGitHubToken(r.TokenPath); tokenErr != nil {`
`114`		`- return errors.Wrapf(tokenErr, "setting GitHub token")`
	`113`	`+ if r.TokenPath != "" {`
	`114`	`+ logrus.Infof("Setting GitHub token: %v", r.TokenPath)`
	`115`	`+ if tokenErr := r.SetGitHubToken(r.TokenPath); tokenErr != nil {`
	`116`	`+ return errors.Wrapf(tokenErr, "setting GitHub token")`
	`117`	`+ }`
`115`	`118`	`}`
`116`	`119`
`117`	`120`	`allKEPs := make([]*api.Proposal, 0, 10)`