Skip to content

Commit 645fee8

Browse files
committed
Updated KEP 2008 to target 1.25
Signed-off-by: Adrian Reber <[email protected]>
1 parent 35d3a8d commit 645fee8

File tree

2 files changed

+26
-12
lines changed

2 files changed

+26
-12
lines changed

keps/sig-node/2008-forensic-container-checkpointing/README.md

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
- [Non-Goals](#non-goals)
99
- [Proposal](#proposal)
1010
- [Implementation](#implementation)
11+
- [CRI Updates](#cri-updates)
1112
- [User Stories](#user-stories)
1213
- [Risks and Mitigations](#risks-and-mitigations)
1314
- [Design Details](#design-details)
@@ -65,7 +66,7 @@ will not be aware of any sandboxed analysis.
6566

6667
### Goals
6768

68-
The goal of this KEP is to introduce *checkpoint* and *restore* to the CRI API.
69+
The goal of this KEP is to introduce *checkpoint* to the CRI API.
6970
This includes extending the *kubelet* API to support checkpointing single
7071
containers with the forensic use case in mind.
7172

@@ -106,13 +107,24 @@ For the first implementation we do not want to support restore in the
106107
outside of Kubernetes. The restore is a container engine only operation
107108
in this first step.
108109

109-
The forensic use case is targeted to be part of the next (1.24) release.
110+
#### CRI Updates
110111

111-
Although this KEP only adds checkpointing support to the kubelet the CRI API in
112-
the corresponding code pull request is extended to support *checkpoint* and
113-
*restore* in the CRI API. The reason to add *restore* to the CRI API without
114-
implementing it in the kubelet is to make development and especially testing
115-
easier on the container engine level.
112+
The CRI API will be extended to introduce one new RPC:
113+
```
114+
// CheckpointContainer checkpoints a container
115+
rpc CheckpointContainer(CheckpointContainerRequest) returns (CheckpointContainerResponse) {}
116+
```
117+
with the following parameters:
118+
```
119+
message CheckpointContainerRequest {
120+
// ID of the container to be checkpointed.
121+
string container_id = 1;
122+
// Location of the checkpoint archive used for export/import
123+
string location = 2;
124+
}
125+
126+
message CheckpointContainerResponse {}
127+
```
116128

117129
### User Stories
118130

@@ -268,6 +280,8 @@ does not compress the checkpoint archive on disk.
268280
* 2021-09-22: Removed everything which is not directly related to the forensic use case
269281
* 2022-01-06: Reworked based on review
270282
* 2022-01-20: Reworked based on review and renamed feature gate to `ContainerCheckpoint`
283+
* 2022-04-05: Added CRI API section and targeted 1.25
284+
* 2022-05-17: Remove *restore* RPC from the CRI API
271285

272286
## Drawbacks
273287

keps/sig-node/2008-forensic-container-checkpointing/kep.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ participating-sigs:
77
- TBD
88
status: implementable
99
creation-date: 2020-09-16
10-
last-updated: 2022-01-20
10+
last-updated: 2022-05-17
1111
reviewers:
1212
- "@mrunalp"
1313
- "@elfinhe"
@@ -22,13 +22,13 @@ stage: alpha
2222
# The most recent milestone for which work toward delivery of this KEP has been
2323
# done. This can be the current (upcoming) milestone, if it is being actively
2424
# worked on.
25-
latest-milestone: "v1.24"
25+
latest-milestone: "v1.25"
2626

2727
# The milestone at which this feature was, or is targeted to be, at each stage.
2828
milestone:
29-
alpha: "v1.24"
30-
beta: "v1.25"
31-
stable: "v1.27"
29+
alpha: "v1.25"
30+
beta: "v1.26"
31+
stable: "v1.28"
3232

3333
# The following PRR answers are required at alpha release
3434
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)