Skip to content

Commit 64a1207

Browse files
committed
Fix toc, verify and go test errors
Signed-off-by: lauralorenz <[email protected]>
1 parent b1feb73 commit 64a1207

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

keps/sig-node/4603-tune-crashloopbackoff/README.md

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -90,14 +90,7 @@ tags, and then generate with `hack/update-toc.sh`.
9090
- [Fast restart on failure](#fast-restart-on-failure)
9191
- [Sidecar containers fast restart](#sidecar-containers-fast-restart)
9292
- [Notes/Constraints/Caveats (Optional)](#notesconstraintscaveats-optional)
93-
- [On Success](#on-success)
94-
- [Risks and Mitigations](#risks-and-mitigations)
95-
- [Design Details](#design-details)
96-
- [Front loaded decay curve methodology](#front-loaded-decay-curve-methodology)
97-
- [New OneOf for <code>restartPolicy</code> -- <code>Rapid</code>](#new-oneof-for-restartpolicy----rapid)
98-
- [Kubelet overhead analysis](#kubelet-overhead-analysis)
99-
- [Observability](#observability)
100-
- [Relationship with Job API podFailurePolicy and backoffLimit](#relationship-with-job-api-podfailurepolicy-and-backofflimit)
93+
- [On Success and the 10 minute recovery threshold](#on-success-and-the-10-minute-recovery-threshold)
10194
- [Relationship with ImagePullBackOff](#relationship-with-imagepullbackoff)
10295
- [Test Plan](#test-plan)
10396
- [Prerequisite testing updates](#prerequisite-testing-updates)
@@ -126,6 +119,7 @@ tags, and then generate with `hack/update-toc.sh`.
126119
- [Related: API opt-in for flat rate/quick restarts when transitioning from <code>Succeeded</code> phase](#related-api-opt-in-for-flat-ratequick-restarts-when-transitioning-from-succeeded-phase)
127120
- [Related: <code>Succeeded</code> vs <code>Rapid</code>ly failing: who's getting the better deal?](#related-succeeded-vs-rapidly-failing-whos-getting-the-better-deal)
128121
- [Front loaded decay with interval](#front-loaded-decay-with-interval)
122+
- [Late recovery](#late-recovery)
129123
- [More complex heuristics](#more-complex-heuristics)
130124
- [Expose podFailurePolicy to nonJob Pods](#expose-podfailurepolicy-to-nonjob-pods)
131125
- [Subsidize running time in backoff delay](#subsidize-running-time-in-backoff-delay)
@@ -730,7 +724,7 @@ This KEP considers changes to ImagePullBackoff as out of scope, so during
730724
implementation this will keep the same backoff. This is both to reduce the
731725
number of variables during the benchmarking period for the restart counter, and
732726
because the problem space of ImagePullBackoff could likely be handled by a
733-
compeltely different pattern, as unlike with CrashLoopBackoff the types of
727+
completely different pattern, as unlike with CrashLoopBackoff the types of
734728
errors with ImagePullBackoff are less variable and better interpretable by the
735729
infrastructure as recovereable or non-recoverable (i.e. 404s).
736730

@@ -1450,7 +1444,7 @@ settings) in kubelet configuration.
14501444

14511445
### Per exit code configuration
14521446

1453-
One alternative is for new contianer spec values that allow individual containers to
1447+
One alternative is for new container spec values that allow individual containers to
14541448
respect overrides on the global timeout behavior depending on the exit reason.
14551449
These overrides will exist for the following reasons:
14561450

@@ -1605,7 +1599,7 @@ That being said, after this initial KEP reaches beta and beyond, it is entirely
16051599
TBD
16061600

16071601
#### Subsidize running time in backoff delay
1608-
FIXME: Subsidize latest succesful pod running time/readinessProbe/livenessProbe
1602+
FIXME: Subsidize latest successful pod running time/readinessProbe/livenessProbe
16091603
into the CrashLoopBackOff backoff, potentially restarting the backoff counter as
16101604
a result
16111605

keps/sig-node/4603-tune-crashloopbackoff/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ feature-gates:
4141
components:
4242
- kube-apiserver
4343
- kubelet
44-
- name: EnableRapidCrashLoopBackoffDecay
44+
- name: EnableRapidCrashLoopBackoffDecay
4545
components:
4646
- kube-apiserver
4747
- kubelet

0 commit comments

Comments
 (0)