Skip to content

Commit 681dbea

Browse files
committed
deads feedback
1 parent c176438 commit 681dbea

File tree

1 file changed

+7
-3
lines changed
  • keps/sig-api-machinery/2885-server-side-unknown-field-validation

1 file changed

+7
-3
lines changed

keps/sig-api-machinery/2885-server-side-unknown-field-validation/README.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -542,11 +542,15 @@ server-side validation is enabled.
542542
to `Warn`. It performs server-side validation, but validation errors are
543543
exposed as warnings in the result header rather than failing the request.
544544

545+
We will introduce a mechanism similar to the cli-runtime
546+
[DryRunVerifier](https://github.com/kubernetes/cli-runtime/blob/cfe3fe3837db26e9afb75e9491348080a4f0ef23/pkg/resource/dry_run_verifier.go#L73:26)
547+
to read the server's published OpenAPI to determine whether or not server-side
548+
validation is enabled on the server.
549+
545550
The goal here is for the flag to be intent based, whether we use client-side or
546551
server-side under the hood is based solely on whether or not server-side
547552
validation is supported by the apiserver kubectl is connected to.
548553

549-
550554
### Test Plan
551555

552556
<!--
@@ -916,8 +920,8 @@ N/A
916920

917921
###### What steps should be taken if SLOs are not being met to determine the problem?
918922

919-
Opt out of server-side validation if the performance impact of it is not
920-
tolerable.
923+
Operators can disable server-side validation by setting the feature-gate to false if
924+
the performance impact of it is not tolerable.
921925

922926
## Implementation History
923927

0 commit comments

Comments
 (0)