Skip to content

Commit 682db90

Browse files
committed
add the issue link as the reference
1 parent 4e9f691 commit 682db90

File tree

1 file changed

+4
-3
lines changed
  • keps/sig-autoscaling/1610-container-resource-autoscaling

1 file changed

+4
-3
lines changed

keps/sig-autoscaling/1610-container-resource-autoscaling/README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -614,6 +614,7 @@ and thus, HPA controller will also do nothing with it.
614614

615615
For existing HPAs, **the current implementation will continue to work on autoscaling based on `ContainerResource`.**
616616
This behavior will be changed to ignore `ContainerResource` when the feature gate is disabled by the beta.
617+
([issue](https://github.com/kubernetes/kubernetes/issues/115467))
617618

618619
### Version Skew Strategy
619620

@@ -731,7 +732,7 @@ You can take a look at one potential example of such test in:
731732
https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282
732733
-->
733734

734-
No. But, the tests to confirm the behavior on switching the feature gate will be added.
735+
No. But, the tests to confirm the behavior on switching the feature gate will be added by beta. ([issue](https://github.com/kubernetes/kubernetes/issues/115467))
735736

736737
### Rollout, Upgrade and Rollback Planning
737738

@@ -765,7 +766,7 @@ What signals should users be paying attention to when the feature is young
765766
that might indicate a serious problem?
766767
-->
767768

768-
- so many HPAs are in `ScalingActive: false` condition with `FailedGetContainerResourceMetric` reason.
769+
- Many HPAs are in `ScalingActive: false` condition with `FailedGetContainerResourceMetric` reason.
769770

770771
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
771772

@@ -776,7 +777,7 @@ are missing a bunch of machinery and tooling and can't do that now.
776777
-->
777778

778779
Not yet.
779-
But, as described in [Are there any tests for feature enablement/disablement?](#Are-there-any-tests-for-feature-enablement/disablement?), the tests to confirm the behavior on switching the feature gate will be added.
780+
But, as described in [Are there any tests for feature enablement/disablement?](#Are-there-any-tests-for-feature-enablement/disablement?), the tests to confirm the behavior on switching the feature gate will be added. ([issue](https://github.com/kubernetes/kubernetes/issues/115467))
780781

781782
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
782783

0 commit comments

Comments
 (0)