api: validate status:implemented == stage:stable

spiffxp · spiffxp · commit 6f464ad1e122 · 2021-10-13T12:53:06.000-07:00
diff --git a/api/proposal.go b/api/proposal.go
@@ -257,6 +257,9 @@ func (k *KEPHandler) Validate(p *Proposal) []error {
 	if err := p.Stage.IsValid(); err != nil {
 		allErrs = append(allErrs, err)
 	}
+	if p.Status == ImplementedStatus && p.Stage != StableStage {
+		allErrs = append(allErrs, fmt.Errorf("status:implemented implies stage:stable but found: %v", p.Stage))
+	}
 	return allErrs
 }
 

Original file line number	Diff line number	Diff line change
`@@ -257,6 +257,9 @@ func (k KEPHandler) Validate(p Proposal) []error {`
`257`	`257`	`if err := p.Stage.IsValid(); err != nil {`
`258`	`258`	`allErrs = append(allErrs, err)`
`259`	`259`	`}`
	`260`	`+ if p.Status == ImplementedStatus && p.Stage != StableStage {`
	`261`	`+ allErrs = append(allErrs, fmt.Errorf("status:implemented implies stage:stable but found: %v", p.Stage))`
	`262`	`+ }`
`260`	`263`	`return allErrs`
`261`	`264`	`}`
`262`	`265`