You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Items marked with (R) are required *prior to targeting to a milestone / release*.
52
56
53
-
-[X] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
57
+
-[x] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
54
58
-[ ] (R) KEP approvers have approved the KEP status as `implementable`
55
59
-[ ] (R) Design details are appropriately documented
56
60
-[ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
61
+
-[ ] e2e Tests for all Beta API Operations (endpoints)
62
+
-[ ] (R) Ensure GA e2e tests for meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
63
+
-[ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
57
64
-[ ] (R) Graduation criteria is in place
65
+
-[ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
58
66
-[ ] (R) Production readiness review completed
59
67
-[ ] (R) Production readiness review approved
60
68
-[ ] "Implementation History" section is up-to-date for milestone
@@ -362,13 +370,28 @@ Even that will help users to avoid recursive relabeling of volumes if their appl
362
370
363
371
### Test Plan
364
372
365
-
* Unit tests:
366
-
* Passing mount options from kubelet to volume plugins.
367
-
* E2e tests:
368
-
* Check no recursive `chcon` is done on a volume when not needed.
369
-
* Check recursive `chcon` is done on a volume when needed.
370
-
* Check that proper metric + alert is emitted when kubelet can't start two pods with different SELinux contexts using the same volume on the same node.
371
-
* These tests might use only CSI volumes, GCEPD in-tree volume plugin that we use for e2e tests might be already migrated to CSI by that time.
373
+
[x] I/we understand the owners of the involved components may require updates to
374
+
existing tests to make this code solid enough prior to committing the changes necessary
No existing / new tests for volume mounting there.
388
+
389
+
##### e2e tests
390
+
391
+
* Check no recursive `chcon` is done on a volume when not needed.
392
+
* Check recursive `chcon` is done on a volume when needed.
393
+
* Check that proper metric + alert is emitted when kubelet can't start two pods with different SELinux contexts using the same volume on the same node._
394
+
* These tests might use only CSI volumes, GCEPD in-tree volume plugin that we use for e2e tests might be already migrated to CSI by that time.
372
395
* Prepare e2e job that runs with SELinux in Enforcing mode!
373
396
374
397
### GraduationCriteria
@@ -383,19 +406,19 @@ Even that will help users to avoid recursive relabeling of volumes if their appl
383
406
* KEP author has access to usage data from OpenShift, a Kubernetes distro that runs with SELinux in enforcing mode.
384
407
* Alpha of Phase2:
385
408
* Onlyif nr. of broken apps is low!
386
-
* To be discussed in sig-storage and sig-arch?.
409
+
* To be discussed in sig-storage and sig-arch?.
387
410
* Publish deprecation note about changed behavior.
388
411
* ImplementPhase2 **with a separate alpha feature gate `SELinuxMount`**.
389
412
* GA: all known issues fixed + deprecation period is over. Otherwise, we will GAPhase1 only.
390
413
391
414
### Upgrade / DowngradeStrategy
392
415
393
416
N/A. This feature affects only mounts. It does not depend on version of Kubernetes on other nodes or in the control plane.
394
-
New / old kubelet will still be able to unmount volumes mounted by old / new kubelet as usual.
417
+
New / old kubelet will still be able to unmount volumes mounted by old / new kubelet as usual.
395
418
396
419
### VersionSkewStrategy
397
420
398
-
N/A. This feature affects only mounts. It does not depend on version of Kubernetes on other nodes or in the control plane.
421
+
N/A. This feature affects only mounts. It does not depend on version of Kubernetes on other nodes or in the control plane.
399
422
400
423
## ProductionReadinessReviewQuestionnaire
401
424
@@ -630,7 +653,7 @@ _This section must be completed when targeting beta graduation to a release._
0 commit comments