Skip to content

Commit 73bd848

Browse files
committed
KEP-2258: Update milestone, reviewers and gate
- Update versions to 1.25+ - Add thockin to reviewers - Update feature gate name to NodeLogViewer
1 parent ed335b3 commit 73bd848

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

keps/sig-windows/2258-node-service-log-viewer/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -191,10 +191,10 @@ configured. Here are some examples:
191191
The `/var/log/` endpoint is enabled using the `enableSystemLogHandler` kubelet
192192
configuration options. To gain access to this new feature this option needs to
193193
be enabled. In addition when introducing this feature it will be hidden behind a
194-
`NodeLogs` feature gate in the kubelet that needs to be explicitly enabled. So
194+
`NodeLogViewer` feature gate in the kubelet that needs to be explicitly enabled. So
195195
you need to enable both options to get access to this new feature and disabling
196196
`enableSystemLogHandler` will disable the new feature irrespective of the
197-
`NodeLogs` feature gate.
197+
`NodeLogViewer` feature gate.
198198

199199
A reference implementation of this feature without the feature gate is
200200
available [here](https://github.com/kubernetes/kubernetes/pull/96120).
@@ -260,12 +260,12 @@ have been added. A reference implementation of the tests can be seen
260260

261261
### Graduation Criteria
262262

263-
The plan is to introduce the feature as alpha in the v1.22 time frame behind the
263+
The plan is to introduce the feature as alpha in the v1.25 time frame behind the
264264
`NodeLogs` feature gate.
265265

266266
#### Alpha -> Beta Graduation
267267

268-
The plan is to graduate the feature to beta in the v1.23 time frame. At that
268+
The plan is to graduate the feature to beta in the v1.26 time frame. At that
269269
point we would have collected feedback from cluster administrators and
270270
developers who have enabled the feature. Based on this feedback and issues
271271
opened we should consider adding a kubelet side throttle for the viewing the
@@ -275,7 +275,7 @@ between file vs journal / WinEvent logs.
275275

276276
#### Beta -> GA Graduation
277277

278-
The plan is to graduate the feature to GA in the v1.24 time frame at which point
278+
The plan is to graduate the feature to GA in the v1.27 time frame at which point
279279
any major issues should have been surfaced and addressed during the alpha and
280280
beta phases.
281281

@@ -293,13 +293,13 @@ viewer, the result should be "feature not supported".
293293

294294
* **How can this feature be enabled / disabled in a live cluster?**
295295
- [x] Feature gate
296-
- Feature gate name: NodeLogs
296+
- Feature gate name: NodeLogViewer
297297
- Components depending on the feature gate: kubelet
298298

299299
* **Does enabling the feature change any default behavior?** No
300300

301301
* **Can the feature be disabled once it has been enabled (i.e. can we roll back
302-
the enablement)?** Yes. It can be disabled by disabling the `NodeLogs` feature
302+
the enablement)?** Yes. It can be disabled by disabling the `NodeLogViewer` feature
303303
gate in the kubelet.
304304

305305
* **What happens if we reenable the feature if it was previously rolled back?**

keps/sig-windows/2258-node-service-log-viewer/kep.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ status: implementable
1212
reviewers:
1313
- "@marosset"
1414
- "@immuzz"
15+
- "@thockin"
1516
approvers:
1617
- "@marosset"
1718
prr-approvers:
@@ -24,18 +25,16 @@ stage: alpha
2425
# The most recent milestone for which work toward delivery of this KEP has been
2526
# done. This can be the current (upcoming) milestone, if it is being actively
2627
# worked on.
27-
latest-milestone: "v1.24"
28+
latest-milestone: "v1.25"
2829

2930
# The milestone at which this feature was, or is targeted to be, at each stage.
3031
milestone:
31-
alpha: "v1.24"
32-
beta: "v1.25"
33-
stable: "v1.26"
32+
alpha: "v1.25"
3433

3534
# The following PRR answers are required at alpha release
3635
# List the feature gate name and the components for which it must be enabled
3736
feature-gates:
38-
- name: NodeLogs
37+
- name: NodeLogViewer
3938
components:
4039
- kubelet
4140
disable-supported: true

0 commit comments

Comments
 (0)