Skip to content

Commit 763ae6d

Browse files
committed
Update the manual test for update/rollback
1 parent a0f4072 commit 763ae6d

File tree

1 file changed

+11
-6
lines changed
  • keps/sig-scheduling/3022-min-domains-in-pod-topology-spread

1 file changed

+11
-6
lines changed

keps/sig-scheduling/3022-min-domains-in-pod-topology-spread/README.md

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -383,18 +383,23 @@ are missing a bunch of machinery and tooling and can't do that now.
383383
Yes. The behavior is changed as expected.
384384

385385
Test scenario:
386-
1. start kube-apiserver where `MinDomains` feature is enabled.
386+
1. start kube-apiserver v1.24 where `MinDomains` feature is disabled.
387387
2. create three nodes and pods spread across nodes as 2/2/1
388388
3. create new Pod that has a TopologySpreadConstraints: maxSkew is 1, topologyKey is `kubernetes.io/hostname`, and minDomains is 4 (larger than the number of domains (= 3)).
389-
4. the Pod created in (3) isn't scheduled because of `MinDomain`.
389+
4. the Pod created in (3) is scheduled because `MinDomain` is disabled.
390390
5. delete the Pod created in (3).
391-
6. recreate kube-apiserver where `MinDomains` feature is disabled.
391+
6. recreate kube-apiserver v1.25 where `MinDomains` feature is enabled.
392392
7. create the same Pod as (3).
393-
8. the Pod created in (7) is scheduled because `MinDomain` is disabled.
393+
8. the Pod created in (7) isn't scheduled because `MinDomain` is enabled and minDomains is larger than the number of domains (= 3)).
394394
9. delete the Pod created in (7).
395-
10. recreate kube-apiserver where `MinDomains` feature is enabled.
395+
10. recreate kube-apiserver v1.24 where `MinDomains` feature is disabled.
396396
11. create the same Pod as (3).
397-
12. the Pod created in (11) isn't scheduled because of `MinDomain`.
397+
12. the Pod created in (11) is scheduled because `MinDomain` is disabled.
398+
13. delete the Pod created in (11).
399+
14. recreate kube-apiserver v1.25 where `MinDomains` feature is enabled.
400+
15. create the same Pod as (3).
401+
16. the Pod created in (15) isn't scheduled because `MinDomain` is enabled and minDomains is larger than the number of domains (= 3)).
402+
17. delete the Pod created in (15).
398403

399404
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
400405

0 commit comments

Comments
 (0)