Skip to content

Commit 764e174

Browse files
committed
Update test plan section
Signed-off-by: lauralorenz <[email protected]>
1 parent 875d4b4 commit 764e174

File tree

1 file changed

+28
-4
lines changed
  • keps/sig-node/4603-tune-crashloopbackoff

1 file changed

+28
-4
lines changed

keps/sig-node/4603-tune-crashloopbackoff/README.md

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ when drafting this test plan.
801801
[testing-guidelines]: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md
802802
-->
803803

804-
[ ] I/we understand the owners of the involved components may require updates to
804+
[x] I/we understand the owners of the involved components may require updates to
805805
existing tests to make this code solid enough prior to committing the changes necessary
806806
to implement this enhancement.
807807

@@ -810,13 +810,27 @@ This feature requires two levels of testing: the regular enhancement testing
810810
increase confidence in ongoing node stability given heterogeneous backoff timers
811811
and timeouts.
812812

813+
Some stress/benchmark testing will still be developed as part of this enhancement,
814+
including the kubelet_perf tests indicated in the e2e section below.
815+
816+
Some of the benefit of pursuing this change in alpha is to also have the
817+
opportunity to run against the existing SIG-Scalability performance and
818+
benchmarking tests within an alpha candidate. In addition, manual benchmark
819+
testing with GKE clusters can be performed by the author and evaluated as
820+
candidates for formal, periodic benchmark testing in the Kubernetes testgrid.
821+
813822
##### Prerequisite testing updates
814823

815824
<!--
816825
Based on reviewers feedback describe what additional tests need to be added prior
817826
implementing this enhancement to ensure the enhancements have also solid foundations.
818827
-->
819828

829+
* Version skew: must have a test to address kubelet handling of noninterpretable
830+
`restartPolicy` values; in this specific case, the value `Rapid`
831+
* Test coverage of proper requeue behavior; see
832+
https://github.com/kubernetes/kubernetes/issues/123602
833+
820834
##### Unit tests
821835

822836
<!--
@@ -838,7 +852,9 @@ This can inform certain test coverage improvements that we want to do before
838852
extending the production code to implement this enhancement.
839853
-->
840854

841-
- `<package>`: `<date>` - `<test coverage>`
855+
- `kubelet/kuberuntime/kuberuntime_manager_test`: **could not find a successful
856+
coverage run on
857+
[prow](https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-coverage-unit/1800947623675301888)**
842858

843859
##### Integration tests
844860

@@ -857,7 +873,9 @@ For Beta and GA, add links to added tests together with links to k8s-triage for
857873
https://storage.googleapis.com/k8s-triage/index.html
858874
-->
859875

860-
- <test>: <link to test coverage>
876+
- k8s.io/kubernetes/test/integration/kubelet:
877+
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-integration-master/1800944856244162560
878+
* test with and without feature flags enabled
861879

862880
##### e2e tests
863881

@@ -871,7 +889,13 @@ https://storage.googleapis.com/k8s-triage/index.html
871889
We expect no non-infra related flakes in the last month as a GA graduation criteria.
872890
-->
873891

874-
- <test>: <link to test coverage>
892+
- k8s.io/kubernetes/test/e2e/node/kubelet_perf: for a given percentage of
893+
heterogenity between "Succeeded" terminating pods, crashing pods whose
894+
`restartPolicy: Always`, and crashing pods whose `restartPolicy: Rapid`,
895+
* what is the load and rate of Pod restart related API requests to the API
896+
server?
897+
* what are the performance (memory, CPU, and pod start latency) effects on the
898+
kubelet component?
875899

876900
### Graduation Criteria
877901

0 commit comments

Comments
 (0)