Skip to content

Commit 78cda8a

Browse files
committed
Supplement the test plan
Signed-off-by: Jian Zeng <[email protected]>
1 parent a29aa12 commit 78cda8a

File tree

1 file changed

+22
-8
lines changed
  • keps/sig-node/3288-separate-stdout-from-stderr

1 file changed

+22
-8
lines changed

keps/sig-node/3288-separate-stdout-from-stderr/README.md

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,8 @@ tags, and then generate with `hack/update-toc.sh`.
9696
- [Integration tests](#integration-tests)
9797
- [e2e tests](#e2e-tests)
9898
- [Graduation Criteria](#graduation-criteria)
99+
- [Alpha](#alpha)
100+
- [Beta](#beta)
99101
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
100102
- [Version Skew Strategy](#version-skew-strategy)
101103
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
@@ -325,9 +327,13 @@ func (s *Server) getContainerLogs(request *restful.Request, response *restful.Re
325327
}
326328
```
327329

330+
We also need to modify the [ReadLogs](https://github.com/kubernetes/kubernetes/blob/198dd7668a19c8749fe45d521d748ef3c653aa73/pkg/kubelet/kuberuntime/logs/logs.go#L281)
331+
function to make it be able to filter out the unwanted stream.
332+
333+
328334
### Changes of kubectl
329335

330-
Add a new flag `--stream`, whose value defaults to empty, to `kubectl logs`, hence users are able to specify the
336+
Add a new flag `--stream`, whose value defaults to "all", to `kubectl logs`, hence users are able to specify the
331337
log stream to return.
332338

333339
### Test Plan
@@ -381,7 +387,9 @@ This can inform certain test coverage improvements that we want to do before
381387
extending the production code to implement this enhancement.
382388
-->
383389

384-
- `<package>`: `<date>` - `<test coverage>`
390+
- `k8s.io/kubernetes/pkg/registry/core/pod/strategy.go`: `2022-06-07` - `59.5%`
391+
- `k8s.io/kubernetes/pkg/kubelet/server/server.go`: `2022-06-07` - `67.8%`
392+
- `k8s.io/kubernetes/pkg/kubelet/kuberuntime/logs/logs.go`: `2022-06-07` - `71%`
385393

386394
##### Integration tests
387395

@@ -392,7 +400,11 @@ For Beta and GA, add links to added tests together with links to k8s-triage for
392400
https://storage.googleapis.com/k8s-triage/index.html
393401
-->
394402

395-
- <test>: <link to test coverage>
403+
Add unit tests to `pkg/kubelet/...` and `pkg/registry/core/pod/...` to make sure kubelet
404+
and kube-apiserver is behaving as expected.
405+
406+
Specifically, when `TailLines` and `Stream` are specified in `PodLogOptions`, we need to ensure that
407+
the counting of TailLines happens properly and only logs from a specified stream were counted.
396408

397409
##### e2e tests
398410

@@ -404,7 +416,7 @@ https://storage.googleapis.com/k8s-triage/index.html
404416
We expect no non-infra related flakes in the last month as a GA graduation criteria.
405417
-->
406418

407-
- <test>: <link to test coverage>
419+
Add test case and conformance test to `test/e2e/common/node/` and `test/e2e/kubectl/`
408420

409421
### Graduation Criteria
410422

@@ -434,17 +446,19 @@ functionality is accessed.
434446
[deprecation-policy]: https://kubernetes.io/docs/reference/using-api/deprecation-policy/
435447
436448
Below are some examples to consider, in addition to the aforementioned [maturity levels][maturity-levels].
449+
-->
437450

438451
#### Alpha
439452

440453
- Feature implemented behind a feature flag
441-
- Initial e2e tests completed and enabled
454+
- Add unit and e2e tests for the feature.
442455

443456
#### Beta
444457

445-
- Gather feedback from developers and surveys
446-
- Complete features A, B, C
447-
- Additional tests are in Testgrid and linked in KEP
458+
- Solicit feedback from the Alpha.
459+
- Ensure tests are stable and passing.
460+
461+
<!--
448462
449463
#### GA
450464

0 commit comments

Comments
 (0)