Merge pull request kubernetes#2027 from soltysh/new_format_staging

Move kubectl-staging to the new KEP format

Author: k8s-ci-robot

keps/sig-cli/kubectl-staging.md renamed to keps/sig-cli/1020-kubectl-staging/README.md

@@ -1,27 +1,7 @@
----
-title: Move Kubectl Code into Staging
-authors:
-  - "@seans3"
-owning-sig: sig-cli
-participating-sigs:
-reviewers:
-  - "@pwittrock"
-  - "@liggitt"
-approvers:
-  - "@soltysh"
-editor: "@seans3"
-creation-date: 2019-04-09
-last-updated: 2019-04-09
-status: implementable
-see-also:
----
-
-
-# Move Kubectl Code into Staging
-
-## Table of Contents
+# KEP-1020: Move Kubectl Code into Staging
 
 <!-- toc -->
+- [Release Signoff Checklist](#release-signoff-checklist)
 - [Summary](#summary)
 - [Motivation](#motivation)
   - [Goals](#goals)
@@ -30,13 +10,35 @@ see-also:
   - [Adding the staging repository in kubernetes/kubernetes:](#adding-the-staging-repository-in-kuberneteskubernetes)
   - [Modify and Set-up the existing receiving kubernetes/kubectl repository](#modify-and-set-up-the-existing-receiving-kuberneteskubectl-repository)
   - [Move <code>pkg/kubectl</code> Code](#move--code)
-  - [Timeframe](#timeframe)
+  - [Time frame](#time-frame)
 - [Risks and Mitigations](#risks-and-mitigations)
 - [Graduation Criteria](#graduation-criteria)
 - [Testing](#testing)
+- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
+  - [Feature Enablement and Rollback](#feature-enablement-and-rollback)
+  - [Rollout, Upgrade and Rollback Planning](#rollout-upgrade-and-rollback-planning)
+  - [Monitoring Requirements](#monitoring-requirements)
+  - [Dependencies](#dependencies)
+  - [Scalability](#scalability)
+  - [Troubleshooting](#troubleshooting)
 - [Implementation History](#implementation-history)
 <!-- /toc -->
 
+## Release Signoff Checklist
+
+Items marked with (R) are required *prior to targeting to a milestone / release*.
+
+- [x] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
+- [X] (R) KEP approvers have approved the KEP status as `implementable`
+- [x] (R) Design details are appropriately documented
+- [x] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
+- [x] (R) Graduation criteria is in place
+- [x] (R) Production readiness review completed
+- [X] Production readiness review approved
+- [x] "Implementation History" section is up-to-date for milestone
+- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
+- [x] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
+
 ## Summary
 
 We propose to move the `pkg/kubectl` code base into staging. This effort would
@@ -155,7 +157,7 @@ Move `k8s.io/kubernetes/pkg/kubectl` to a location under the new
 `k8s.io/kubernetes/staging/src/k8s.io/kubectl` directory, and update all
 `k8s.io/kubernetes/pkg/kubectl` imports. This can be an incremental process.
 
-### Timeframe
+### Time frame
 
 There are three remaining Kubernetes core dependencies that have to be resolved
 before all of `pkg/kubectl` can be moved to staging. While we work on those
@@ -167,7 +169,7 @@ would be moved over the next two releases (1.16 and 1.17).
 ## Risks and Mitigations
 
 If a project vendors Kubernetes to import kubectl code, this will break them.
-On the bright side, afterwards, these importers will have a much cleaner path to 
+On the bright side, afterwards, these importers will have a much cleaner path to
 include kubectl code. Before moving forward with this plan, we will identify and
 communicate to these projects.
 
@@ -182,6 +184,105 @@ Except for kubectl developers, this change will be mostly transparent. There is
 no new functionality to test; testing will be accomplished through the current
 unit tests, integration tests, and end-to-end tests.
 
+## Production Readiness Review Questionnaire
+
+### Feature Enablement and Rollback
+
+
+* **How can this feature be enabled / disabled in a live cluster?**
+  Not aplicable.
+
+* **Does enabling the feature change any default behavior?**
+  Not applicable.
+
+* **Can the feature be disabled once it has been enabled (i.e. can we roll back
+  the enablement)?**
+  Not applicable.
+
+* **What happens if we reenable the feature if it was previously rolled back?**
+  Not applicable.
+
+* **Are there any tests for feature enablement/disablement?**
+  Not applicable.
+
+### Rollout, Upgrade and Rollback Planning
+
+* **How can a rollout fail? Can it impact already running workloads?**
+  Not applicable.
+
+* **What specific metrics should inform a rollback?**
+  Not applicable.
+
+* **Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?**
+  Not applicable.
+
+* **Is the rollout accompanied by any deprecations and/or removals of features, APIs,
+fields of API types, flags, etc.?**
+  Not applicable.
+
+### Monitoring Requirements
+
+* **How can an operator determine if the feature is in use by workloads?**
+  Not applicable.
+
+* **What are the SLIs (Service Level Indicators) an operator can use to determine
+the health of the service?**
+  Not applicable.
+
+* **What are the reasonable SLOs (Service Level Objectives) for the above SLIs?**
+  Not applicable.
+
+* **Are there any missing metrics that would be useful to have to improve observability
+of this feature?**
+  Not applicable.
+
+### Dependencies
+
+* **Does this feature depend on any specific services running in the cluster?**
+  Not applicable.
+
+### Scalability
+
+* **Will enabling / using this feature result in any new API calls?**
+  Not applicable.
+
+* **Will enabling / using this feature result in introducing new API types?**
+  Not applicable.
+
+* **Will enabling / using this feature result in any new calls to the cloud
+provider?**
+  Not applicable.
+
+* **Will enabling / using this feature result in increasing size or count of
+the existing API objects?**
+  Not applicable.
+
+* **Will enabling / using this feature result in increasing time taken by any
+operations covered by [existing SLIs/SLOs]?**
+  Not applicable.
+
+* **Will enabling / using this feature result in non-negligible increase of
+resource usage (CPU, RAM, disk, IO, ...) in any components?**
+  Not applicable.
+
+### Troubleshooting
+
+The Troubleshooting section currently serves the `Playbook` role. We may consider
+splitting it into a dedicated `Playbook` document (potentially with some monitoring
+details). For now, we leave it here.
+
+* **How does this feature react if the API server and/or etcd is unavailable?**
+  Not applicable.
+
+* **What are other known failure modes?**
+  Not applicable.
+
+* **What steps should be taken if SLOs are not being met to determine the problem?**
+  Not applicable.
+
+[supported limits]: https://git.k8s.io/community//sig-scalability/configs-and-limits/thresholds.md
+[existing SLIs/SLOs]: https://git.k8s.io/community/sig-scalability/slos/slos.md#kubernetes-slisslos
+
 ## Implementation History
 
 See [kubernetes/kubectl#80](https://github.com/kubernetes/kubectl/issues/80) as

keps/sig-cli/1020-kubectl-staging/kep.yaml

@@ -0,0 +1,40 @@
+title: Move Kubectl Code into Staging
+kep-number: 1020
+authors:
+  - "@seans3"
+  - "@soltysh"
+owning-sig: sig-cli
+participating-sigs:
+status: implementable
+creation-date: 2019-04-09
+reviewers:
+  - "@pwittrock"
+  - "@liggitt"
+approvers:
+  - "@pwittrock"
+prr-approvers:
+  - "@deads2k"
+see-also:
+replaces:
+
+# The target maturity stage in the current dev cycle for this KEP.
+stage: stable
+
+# The most recent milestone for which work toward delivery of this KEP has been
+# done. This can be the current (upcoming) milestone, if it is being actively
+# worked on.
+latest-milestone: "v1.20"
+
+# The milestone at which this feature was, or is targeted to be, at each stage.
+milestone:
+  alpha: "v1.15"
+  beta: "v1.19"
+  stable: "v1.20"
+
+# The following PRR answers are required at alpha release
+# List the feature gate name and the components for which it must be enabled
+feature-gates:
+disable-supported: false
+
+# The following PRR answers are required at beta release
+metrics: