Skip to content

Commit 7d0135a

Browse files
committed
KEP-4438: add missing sections
Signed-off-by: Matthias Bertschy <[email protected]>
1 parent d62cf9a commit 7d0135a

File tree

1 file changed

+18
-0
lines changed
  • keps/sig-node/4438-container-restart-termination

1 file changed

+18
-0
lines changed

keps/sig-node/4438-container-restart-termination/README.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,14 @@ How will UX be reviewed, and by whom?
277277
Consider including folks who also work outside the SIG or subproject.
278278
-->
279279

280+
The main risk of this proposal is that the lifecycle of sidecar containers will be changed, which could
281+
potentially break existing behavior. To mitigate this risk, we will introduce several e2e tests
282+
and peer review to ensure that the changes are safe.
283+
284+
There is no security impact of this proposal.
285+
286+
The UX impact of this proposal is minimal, as it adds an expected behavior to the lifecycle of sidecar containers.
287+
280288
## Design Details
281289

282290
<!--
@@ -902,6 +910,11 @@ Major milestones might include:
902910
Why should this KEP _not_ be implemented?
903911
-->
904912

913+
The main drawback of this KEP is that it introduces a new feature gate for the sidecars,
914+
which can be confusing for users. However, we believe that the current behavior of sidecar containers
915+
is already useful and that the restart during Pod termination feature is not critical for many use cases.
916+
This is why this feature is introduced as a separate feature gate, so that KEP-753 can reach GA faster.
917+
905918
## Alternatives
906919

907920
<!--
@@ -910,6 +923,11 @@ not need to be as detailed as the proposal, but should include enough
910923
information to express the idea and why it was not acceptable.
911924
-->
912925

926+
The alternative would be to introduce KEP-753 with the restart during Pod termination feature.
927+
However, this would have required a significant refactoring of the kubelet
928+
and the Pod lifecycle, which would introduce a risk of disruption to users. This is why we decided to
929+
introduce a separate feature gate for the sidecar containers feature.
930+
913931
## Infrastructure Needed (Optional)
914932

915933
<!--

0 commit comments

Comments
 (0)