Skip to content

Commit 7eadd9f

Browse files
Clarified PRR question about reenabling feature gate
1 parent 9508d34 commit 7eadd9f

File tree

1 file changed

+5
-1
lines changed
  • keps/sig-node/4960-container-stop-signals

1 file changed

+5
-1
lines changed

keps/sig-node/4960-container-stop-signals/README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,11 @@ Yes, the feature gate can be turned off to disable the feature once it has been
360360

361361
###### What happens if we reenable the feature if it was previously rolled back?
362362

363-
If you reenable the feature, you'll be able to create Pods with StopSignal lifecycle hooks for their containers. Without the feature gate enabled, this would make your workloads invalid.
363+
If you reenable the feature, you'll be able to create Pods with StopSignal lifecycle hooks for their containers. Once the gate is disabled, if you try to create new Pods with StopSignal, those would be invalid and wouldn't pass validation. Existing worklods using StopSignal should still continue to function.
364+
365+
If the feature gate is turned off in the kubelet alone, users would be able to create Pods with StopSignal, but the field will be dropped in the kubelet. When they turn the feature gate back on in the kubelet, the kubelet would start sending the StopSignal to the container runtime again, and the container runtime starts using the custom stop signal to kill the containers. If cluster operator disables or reenables the feature gate, no change should happen to exisiting workloads.
366+
367+
When the kubelet restarts after the feature gate is reenabled, it polls the CRI implementation for existing containers and then compares them to the ones that the API is requesting. It is recommended to drain the node before enabling/disabling the feature gate in the kubelet.
364368

365369
###### Are there any tests for feature enablement/disablement?
366370

0 commit comments

Comments
 (0)