Skip to content

Commit 7f54dfb

Browse files
author
Ricardo Katz
committed
Propose promotion of endPort to GA
1 parent 4903b97 commit 7f54dfb

File tree

2 files changed

+32
-8
lines changed

2 files changed

+32
-8
lines changed

keps/sig-network/2079-network-policy-port-range/README.md

Lines changed: 30 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@
1616
- [Design Details](#design-details)
1717
- [Validations](#validations)
1818
- [Test Plan](#test-plan)
19+
- [Prerequisite testing updates](#prerequisite-testing-updates)
20+
- [Unit tests](#unit-tests)
21+
- [e2e tests](#e2e-tests)
1922
- [Graduation Criteria](#graduation-criteria)
2023
- [Alpha](#alpha)
2124
- [Beta](#beta)
@@ -181,6 +184,12 @@ The `NetworkPolicyPort` will need to be validated, with the following scenarios:
181184

182185
### Test Plan
183186

187+
[X] I/we understand the owners of the involved components may require updates to
188+
existing tests to make this code solid enough prior to committing the changes necessary
189+
to implement this enhancement.
190+
191+
##### Prerequisite testing updates
192+
184193
Unit tests:
185194
* test API validation logic
186195
* test API strategy to ensure disabled fields
@@ -189,6 +198,15 @@ E2E tests:
189198
* Add e2e tests exercising only the API operations for port ranges. Data-path
190199
validation should be done by CNIs.
191200

201+
##### Unit tests
202+
203+
- `pkg/apis/networking/validation/validation`: `14/Jun/2022` - `92.5%`
204+
- `pkg/registry/networking/networkpolicy/strategy`: `14/Jun/2022` - `75.9%`
205+
206+
##### e2e tests
207+
208+
- test/e2e/network/netpol/network_policy_api.go: Test is optional as per the whole Network Policy suite
209+
192210

193211
### Graduation Criteria
194212

@@ -257,7 +275,6 @@ start working incorrectly. This is a fail-closed failure, so it is acceptable.
257275

258276
### Rollout, Upgrade and Rollback Planning
259277

260-
_This section must be completed when targeting beta graduation to a release._
261278
###### How can a rollout or rollback fail? Can it impact already running workloads?
262279
Not probably, but still there's the risk of some bug that fails validation,
263280
or conversion function crashes.
@@ -276,13 +293,17 @@ _This section must be completed when targeting beta graduation to a release._
276293

277294
### Monitoring Requirements
278295

279-
_This section must be completed when targeting beta graduation to a release._
280296
###### How can an operator determine if the feature is in use by workloads?
281297

282298

283299
Operators can determine if NetworkPolicies are making use of EndPort creating
284300
an object specifying the range and validating if the traffic is allowed within
285-
the specified range
301+
the specified range.
302+
303+
Also Network Policy object now supports (as alpha) status/condition fields, so
304+
Network Policy providers can add a feedback to the user whether the policy was processed
305+
correctly or not. Providing this feedback is optional and depends on implementation
306+
by each NPP.
286307

287308
###### How can someone using this feature know that it is working for their instance?
288309

@@ -293,8 +314,11 @@ _This section must be completed when targeting beta graduation to a release._
293314
look into CNI metrics to check if the rules are being applied correctly, like Calico
294315
that provides metrics like `felix_iptables_restore_errors` that can be used to
295316
verify if the amount of restoring errors raised after the feature being applied.
296-
We might need in a future to add some Status field that allows CNI providers to provide
297-
feedback about the functionality
317+
For NetworkPolicy Providers that doesn't support this feature, a new status field was added
318+
in Network Policy object allowing the providers to give feedback to users using conditions.
319+
Any NPP that does not support this feature should add a condition on the Network Policy
320+
object.
321+
298322

299323
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
300324

@@ -362,7 +386,7 @@ of this feature?**
362386
lead to undesired Network Policy, blocking previously working rules.
363387

364388
## Implementation History
365-
- 2022-01-31 Propose GA graduation
389+
- 2022-06-14 Propose GA graduation
366390
- 2021-05-11 Propose Beta graduation and add more Performance Review data
367391
- 2020-10-08 Initial [KEP PR](https://github.com/kubernetes/enhancements/pull/2079)
368392

keps/sig-network/2079-network-policy-port-range/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@ stage: stable
1818
# The most recent milestone for which work toward delivery of this KEP has been
1919
# done. This can be the current (upcoming) milestone, if it is being actively
2020
# worked on.
21-
latest-milestone: "v1.24"
21+
latest-milestone: "v1.25"
2222

2323
# The milestone at which this feature was, or is targeted to be, at each stage.
2424
milestone:
2525
alpha: "v1.21"
2626
beta: "v1.22"
27-
stable: "v1.24"
27+
stable: "v1.25"
2828

2929
# The following PRR answers are required at alpha release
3030
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)