Skip to content

Commit 889a998

Browse files
authored
Merge pull request kubernetes#3423 from nabokihms/3325-update-tests-plan
KEP-3325: Update test plan section
2 parents d3df65f + 9c4896a commit 889a998

File tree

1 file changed

+64
-5
lines changed
  • keps/sig-auth/3325-self-subject-attributes-review-api

1 file changed

+64
-5
lines changed

keps/sig-auth/3325-self-subject-attributes-review-api/README.md

Lines changed: 64 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@
1111
- [Request](#request)
1212
- [RBAC](#rbac)
1313
- [Test Plan](#test-plan)
14+
- [Prerequisite testing updates](#prerequisite-testing-updates)
15+
- [Unit tests](#unit-tests)
16+
- [Integration tests](#integration-tests)
17+
- [e2e tests](#e2e-tests)
1418
- [Graduation Criteria](#graduation-criteria)
1519
- [Alpha](#alpha)
1620
- [Beta](#beta)
@@ -175,21 +179,76 @@ If necessary, it will be possible to disable this API by using the following kub
175179

176180
### Test Plan
177181

178-
Unit tests covering:
182+
[X] I/we understand the owners of the involved components may require updates to
183+
existing tests to make this code solid enough prior to committing the changes necessary
184+
to implement this enhancement.
185+
186+
##### Prerequisite testing updates
187+
188+
<!--
189+
Based on reviewers feedback describe what additional tests need to be added prior
190+
implementing this enhancement to ensure the enhancements have also solid foundations.
191+
-->
192+
193+
N/A
194+
195+
##### Unit tests
196+
197+
<!--
198+
In principle every added code should have complete unit test coverage, so providing
199+
the exact set of tests will not bring additional value.
200+
However, if complete unit test coverage is not possible, explain the reason of it
201+
together with explanation why this is acceptable.
202+
-->
203+
204+
<!--
205+
Additionally, for Alpha try to enumerate the core package you will be touching
206+
to implement this enhancement and provide the current unit coverage for those
207+
in the form of:
208+
- <package>: <date> - <current test coverage>
209+
The data can be easily read from:
210+
https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit
211+
This can inform certain test coverage improvements that we want to do before
212+
extending the production code to implement this enhancement.
213+
-->
214+
215+
The plan to test the SelfSubjectAttributesReview API is:
179216

180217
1. Request returns all user attributes
181218
2. Request returns some user attributes
182219
3. Request with a status returns overridden fields
183220

184-
Integration tests covering:
221+
Command line interface tests covering:
222+
1. How successful responses are rendered in the terminal with various output modes.
223+
2. How errors are rendered.
224+
225+
Given that a new API package is introduced as part of this feature there is
226+
no existing test coverage to link to.
227+
228+
##### Integration tests
229+
230+
<!--
231+
This question should be filled when targeting a release.
232+
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
233+
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
234+
https://storage.googleapis.com/k8s-triage/index.html
235+
-->
185236

186237
1. Successful authentication through a simple authenticator, e.g., token or certificate authenticator
187238
2. Successful authentication through a complicated authenticator, e.g., webhook or authentication proxy authenticator
188239
3. Failed authentication
189240

190-
Command line interface tests covering:
191-
1. How successful responses are rendered in the terminal with various output modes.
192-
2. How errors are rendered.
241+
##### e2e tests
242+
243+
<!--
244+
This question should be filled when targeting a release.
245+
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
246+
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
247+
https://storage.googleapis.com/k8s-triage/index.html
248+
We expect no non-infra related flakes in the last month as a GA graduation criteria.
249+
-->
250+
251+
There are no e2e tests planned for the alpha milestone.
193252

194253
### Graduation Criteria
195254

0 commit comments

Comments
 (0)