Skip to content

Commit 890cc22

Browse files
marossetsoltysh
andauthored
Apply suggestions from code review
Co-authored-by: Maciej Szulik <[email protected]>
1 parent de8d550 commit 890cc22

File tree

1 file changed

+4
-4
lines changed
  • keps/sig-windows/5100-windows-dsr-and-overlay-support

1 file changed

+4
-4
lines changed

keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ Since the functionality is already implemented, the design details section will
301301
DSR is enabled by passing `--enable-dsr=true` as a command line switch to the Windows kube-proxy.
302302
Prior to GA, kube-proxy will ensure that `WinDSR=true` is specified in the feature-gates and will fail to start if DSR is enabled without that.
303303

304-
Checks for ternminating and service enpoints handle DSR traffic differently than non-DSR traffic to adhere to behavior defined in [KEP-1669: Proxy Terminating Endpoints](https://github.com/kubernetes/enhancements/issues/1669)
304+
Checks for terminating and service endpoints handle DSR traffic differently than non-DSR traffic to adhere to behavior defined in [KEP-1669: Proxy Terminating Endpoints](https://github.com/kubernetes/enhancements/issues/1669)
305305
- Local endpoints will be skipped when determining if all endpoints for a service are terminated if DSR is enabled and service type is load balancer.
306306
- Non-local endpoints will be skipped when considering if all endpoints for a service are non-serving if DSR is enabled and service type is load balancer.
307307

@@ -603,7 +603,7 @@ NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
603603

604604
For DSR, yes, DSR can be disabled by passing `--enable-dsr=false` as a kube-proxy command line switch and restarting kube-proxy.
605605

606-
FOr Overlay, no, overlay networking mode cannot be disabled on a per-node basis. All nodes in a cluster must use the same network type so it is not possible to switch between overlay and bridge networking on a per-node basis.
606+
For Overlay, no, overlay networking mode cannot be disabled on a per-node basis. All nodes in a cluster must use the same network type so it is not possible to switch between overlay and bridge networking on a per-node basis.
607607

608608
###### What happens if we reenable the feature if it was previously rolled back?
609609

@@ -646,7 +646,7 @@ rollout. Similarly, consider large clusters and how enablement/disablement
646646
will rollout across nodes.
647647
-->
648648

649-
For DSR a rollout or rollback should not fail. Nodes can operator with DSR enabled or disabled per node in a cluster.
649+
For DSR a rollout or rollback should not fail. Nodes can operate with DSR enabled or disabled per node in a cluster.
650650

651651
For overlay networking mode support, a rollout can fail if the CNI configuration for the node and kube-proxy configuration are not in sync. This would cause nodes to never go into the Ready state.
652652

@@ -657,7 +657,7 @@ What signals should users be paying attention to when the feature is young
657657
that might indicate a serious problem?
658658
-->
659659

660-
Node ready state should be monitored to ensure nodes job the cluster and are properly configured to start running pods.
660+
Node ready state should be monitored to ensure nodes join the cluster and are properly configured to start running pods.
661661

662662
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
663663

0 commit comments

Comments
 (0)