Merge pull request kubernetes#4912 from kerthcet/feat/graduate-to-ga

KEP-3094: Graduate NodeInclusionPolicyInPodTopologySpread to GA

Author: k8s-ci-robot

keps/prod-readiness/sig-scheduling/3094.yaml

@@ -3,3 +3,5 @@ alpha:
   approver: "@wojtek-t"
 beta:
   approver: "@wojtek-t"
+stable:
+  approver: "@wojtek-t"

keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md

@@ -134,16 +134,16 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
 - [x] (R) KEP approvers have approved the KEP status as `implementable`
 - [x] (R) Design details are appropriately documented
 - [x] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
-  - [ ] e2e Tests for all Beta API Operations (endpoints)
+  - [x] e2e Tests for all Beta API Operations (endpoints)
   - [ ] (R) Ensure GA e2e tests for meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
-  - [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
+  - [x] (R) Minimum Two Week Window for GA e2e tests to prove flake free
 - [x] (R) Graduation criteria is in place
-  - [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
-- [ ] (R) Production readiness review completed
+  - [x] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
+- [x] (R) Production readiness review completed
 - [ ] (R) Production readiness review approved
 - [x] "Implementation History" section is up-to-date for milestone
-- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
-- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
+- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
+- [x] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
 
 <!--
 **Note:** This checklist is iterative and should be reviewed and updated every time this enhancement is being considered for a milestone.
@@ -364,11 +364,11 @@ This can inform certain test coverage improvements that we want to do before
 extending the production code to implement this enhancement.
 -->
 
-- `pkg/api/pod`: `2022-06-17` - `66.7%`
-- `pkg/apis/core/validation`: `2022-06-17` - `82.1%`
-- `pkg/scheduler`: `2022-06-17` - `75%`
-- `pkg/scheduler/framework/plugins/defaultpreemption`: `2022-06-17` - `85.2%`
-- `pkg/scheduler/framework/plugins/podtopologyspread`: `2022-06-17` - `86%`
+- `pkg/api/pod`: `2025-02-10` - `79.1%`
+- `pkg/apis/core/validation`: `2025-02-10` - `84.4%`
+- `pkg/scheduler`: `2025-02-10` - `80.7%`
+- `pkg/scheduler/framework/plugins/defaultpreemption`: `2025-02-10` - `80.4%`
+- `pkg/scheduler/framework/plugins/podtopologyspread`: `2025-02-10` - `87.5%`
 
 ##### Integration tests
 
@@ -566,7 +566,8 @@ feature, can it break the existing applications?).
 
 NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
 -->
-Yes, we can just disable the feature gate.
+The feature can be disabled in Alpha and Beta stage, but once GA, there's no way to disable it.
+But you can leave it opt-out by unset the two fields, and it will fall back to the default behavior.
 
 ###### What happens if we reenable the feature if it was previously rolled back?
 The policies are respected again.
@@ -792,8 +793,7 @@ Describe the metrics themselves and the reasons why they weren't added (e.g., co
 implementation difficulties, etc.).
 -->
 
-Yes, we have a plan to improve observability via metrics [here](https://github.com/kubernetes/kubernetes/issues/110643),
-but still on the way.
+No.
 
 ### Dependencies
 
@@ -954,6 +954,7 @@ Major milestones might include:
 - 2021.01.12: KEP proposed for review, including motivation, proposal, risks,
 test plan and graduation criteria.
 - 2022.09.22: Graduate to Beta in v1.26.
+- 2024.10.10: Graduate to GA in v1.33.
 
 ## Drawbacks
 

keps/sig-scheduling/3094-pod-topology-spread-considering-taints/kep.yaml

@@ -17,18 +17,18 @@ see-also:
   - "/keps/sig-scheduling/1258-default-pod-topology-spread"
 
 # The target maturity stage in the current dev cycle for this KEP.
-stage: beta
+stage: stable
 
 # The most recent milestone for which work toward delivery of this KEP has been
 # done. This can be the current (upcoming) milestone, if it is being actively
 # worked on.
-latest-milestone: "v1.25"
+latest-milestone: "v1.33"
 
 # The milestone at which this feature was, or is targeted to be, at each stage.
 milestone:
   alpha: "v1.25"
   beta: "v1.26"
-  stable: ""
+  stable: "1.33"
 
 # The following PRR answers are required at alpha release
 # List the feature gate name and the components for which it must be enabled
@@ -39,3 +39,7 @@ feature-gates:
       - kube-scheduler
 
 disable-supported: false
+
+metrics:
+- plugin_execution_duration_seconds{plugin="PodTopologySpread"}
+- schedule_attempts_total{result="error|unschedulable"}